Bug#601590: [debhelper] debhelper: cmake buildsystem does not clean builddir if cancelled during configure

2011-07-21 Thread Modestas Vainius
Hello, On ketvirtadienis 21 Liepa 2011 00:22:20 gregory hainaut wrote: Package: debhelper Version: 8.9.1 Tags: patch Hello all, I'm facing the same issue for a personal project. In the correct run, debhelper detect the clean phase as a makefile build. However in our case the Makefile

Bug#601590: [debhelper] debhelper: cmake buildsystem does not clean builddir if cancelled during configure

2011-07-21 Thread Gregory Hainaut
On Thu, Jul 21, 2011 at 8:35 AM, Modestas Vainius mo...@debian.org wrote: Hello, On ketvirtadienis 21 Liepa 2011 00:22:20 gregory hainaut wrote: Package: debhelper Version: 8.9.1 Tags: patch Hello all, I'm facing the same issue for a personal project. In the correct run,

Bug#601590: [debhelper] debhelper: cmake buildsystem does not clean builddir if cancelled during configure

2011-07-21 Thread Modestas Vainius
Hello, On ketvirtadienis 21 Liepa 2011 12:23:29 Gregory Hainaut wrote: Well in this corner-case situation the idea was to remove the buildir, not to call `make clean`. Actually the current code never call `make clean` because rmdir_builddir nukes the builddir that contains the makefile.

Bug#601590: [debhelper] debhelper: cmake buildsystem does not clean builddir if cancelled during configure

2011-07-21 Thread gregory hainaut
On Thu, 21 Jul 2011 14:53:09 +0300 Modestas Vainius mo...@debian.org wrote: Well, ok. In either case, the second hunk of your patch is redundant. That clean code is already implicit due to inheritance from makefile buildsystem. However, this bug is not about cmake actually. I think it

Bug#601590: [debhelper] debhelper: cmake buildsystem does not clean builddir if cancelled during configure

2011-07-20 Thread gregory hainaut
Package: debhelper Version: 8.9.1 Tags: patch Hello all, I'm facing the same issue for a personal project. In the correct run, debhelper detect the clean phase as a makefile build. However in our case the Makefile did not exist. The logic to detect the cmake build is only enabled during the