Bug#616194: acpid: FTBFS (error: comparison between signed and unsigned integer expressions)

2011-03-03 Thread Jonathan Nieder
Jonathan Nieder wrote: --- a/debian/control +++ b/debian/control @@ -5,7 +5,7 @@ Maintainer: Debian Acpi Team pkg-acpi-de...@lists.alioth.debian.org Uploaders: Michael Meskes mes...@debian.org, Loic Minier l...@dooz.org Standards-Version: 3.9.1 -Build-Depends: debhelper (=

Bug#616194: [Pkg-acpi-devel] Bug#616194: acpid: FTBFS (error: comparison between signed and unsigned integer expressions)

2011-03-03 Thread Michael Meskes
How about this patch? I prefer fixing the bug over working around it. Even makes the patch smaller: --- acpid-2.0.8.orig/kacpimon/libnetlink.c +++ acpid-2.0.8/kacpimon/libnetlink.c @@ -518,7 +518,7 @@ int addraw_l(struct nlmsghdr *n, int maxlen, const void *data, int len) { - if

Bug#616194: acpid: FTBFS (error: comparison between signed and unsigned integer expressions)

2011-03-03 Thread Jonathan Nieder
Hi, Michael Meskes wrote: I prefer fixing the bug over working around it. Even makes the patch smaller: I should mention that gcc-4.6 gives another warning[1]. In general I think -Werror is a good tool for development but not so good when autobuilding, since warnings can subtly vary from

Bug#616194: acpid: FTBFS (error: comparison between signed and unsigned integer expressions

2011-03-03 Thread Jonathan Nieder
user debian-...@lists.debian.org clone 616194 -1 severity -1 important retitle -1 acpid: will FTBFS with gcc-4.6 (error: variable ‘type’ set but not used [-Werror=unused-but-set-variable]) usertags -1 - ftbfs-gcc-4.5 ftbfs-gcc-4.4 block 615157 by -1 quit Michael Meskes wrote: * Make both

Bug#616194: acpid: FTBFS (error: comparison between signed and unsigned integer expressions)

2011-03-03 Thread Michael Meskes
I should mention that gcc-4.6 gives another warning[1]. In general I Sorry, I didn't see that as I dn't use gcc-4.6. think -Werror is a good tool for development but not so good when autobuilding, since warnings can subtly vary from version to version and platform to platform. Which is

Bug#616194: acpid: FTBFS (error: comparison between signed and unsigned integer expressions)

2011-03-03 Thread Jonathan Nieder
Michael Meskes wrote: Sorry, I didn't see that as I dn't use gcc-4.6. No problem; I should have mentioned it before. Which is why I think it should stay in there. We build on way more systems than upstream probably can, so keeping -Werror in will help the package. Fair enough. Now that

Bug#616194: acpid: FTBFS (error: comparison between signed and unsigned integer expressions)

2011-03-02 Thread Jonathan Nieder
Source: acpid Version: 1:2.0.7-1 Severity: serious User: debian-...@lists.debian.org Usertags: ftbfs-gcc-4.6 ftbfs-gcc-4.5 ftbfs-gcc-4.4 Tags: patch Hi, Trying to build from source (first with gcc-4.6 as gcc and cc, then gcc-4.5, then gcc-4.4): | $ debian/rules build | cc -g -O2 -Wall -Wextra