Package: buildd
Severity: normal

When dealing with configuration without take_from_dists, it ends up
calling Buildd::DistConf::new_hash() with a hash ref but new_hash()
is expecting a hash.
This leads to complains about being unable to find needed configuration
informations (I don't have the exact error message anymore).

I'm joining to this bug a proposed fix for this.

Thanks.

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.37-rsbac-1-lebrac (PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

>From 579ea84de6f7c12a7c2e770aa14d034b2d0affa5 Mon Sep 17 00:00:00 2001
From: Arnaud Patard <arnaud.pat...@rtp-net.org>
Date: Tue, 19 Jul 2011 09:50:47 +0200
Subject: [PATCH 2/2] Buildd: fix configuration parsing

When dealing with configuration without take_from_dists, it ends up
calling Buildd::DistConf::new_hash() with a hash ref but new_hash()
is expecting a hash. Fix that by using same kind of arguments as
the one used in the other new_hash() calls.

Signed-off-by: Arnaud Patard <arnaud.pat...@rtp-net.org>
---
 lib/Buildd/Conf.pm |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/lib/Buildd/Conf.pm b/lib/Buildd/Conf.pm
index dcf4bd0..2bd5324 100644
--- a/lib/Buildd/Conf.pm
+++ b/lib/Buildd/Conf.pm
@@ -532,7 +532,8 @@ if (\@take_from_dists) {
 	#Make one entry per distribution, it's easier later on:
 	for my \$dist (\@dist_names) {
 	    \$entry{'DIST_NAME'} = \$dist;
-                    my \$dist_config = Buildd::DistConf::new_hash(\\\%entry);
+                    my \$dist_config = Buildd::DistConf::new_hash(CHECK=>$conf->{'CHECK'},
+						      HASH=>\\\%entry);
                     push \@distributions_info, \$dist_config;
 	}
     }
-- 
1.7.4.1

Reply via email to