Bug#636700: update-alternatives: Don't update alternative symlinks if they are already correct

2011-09-09 Thread Guillem Jover
On Fri, 2011-08-26 at 21:36:31 +0200, Raphael Hertzog wrote: On Fri, 26 Aug 2011, Guillem Jover wrote: +static bool +alternative_path_needs_update(const char *linkname, const char *filename) IMO you could just as well drop it entirely since you call xreadlink(linkname, false) (i.e. it

Bug#636700: update-alternatives: Don't update alternative symlinks if they are already correct

2011-08-26 Thread Salvatore Bonaccorso
Hey Raphael On Tue, Aug 16, 2011 at 10:11:03PM +0200, Raphael Hertzog wrote: Hi Salvatore, On Tue, 16 Aug 2011, Salvatore Bonaccorso wrote: Attached is a tentative patch trying to solve this: a link should only be updated, if it does not point to the right place. Can you add a

Bug#636700: update-alternatives: Don't update alternative symlinks if they are already correct

2011-08-26 Thread Raphael Hertzog
Hi, On Fri, 26 Aug 2011, Salvatore Bonaccorso wrote: But attached is an updated version for the patch, is this better suitable so far? Jan, changed the parts you mentioned. Yes, it's better but still two small points remain: +static bool +alternative_link_needs_update(const char *linkname,

Bug#636700: update-alternatives: Don't update alternative symlinks if they are already correct

2011-08-26 Thread Guillem Jover
Hi! On Fri, 2011-08-26 at 08:44:13 +0200, Salvatore Bonaccorso wrote: But attached is an updated version for the patch, is this better suitable so far? Jan, changed the parts you mentioned. The other day while I was messing with u-a I prepared the attached patch which I think is better (but

Bug#636700: update-alternatives: Don't update alternative symlinks if they are already correct

2011-08-26 Thread Raphael Hertzog
Hello Guillem, On Fri, 26 Aug 2011, Guillem Jover wrote: The other day while I was messing with u-a I prepared the attached patch which I think is better (but actually pretty close to what you have now here :). But forgot including it in my push. In any case I'll include it for my next one.

Bug#636700: update-alternatives: Don't update alternative symlinks if they are already correct

2011-08-16 Thread Salvatore Bonaccorso
tag 636700 + patch thanks Hi dpkg Team! On Fri, Aug 05, 2011 at 02:18:58PM +0200, Salvatore Bonaccorso wrote: Indeed in the above setup, /usr/lib/nvidia does not have to be touched, as it is already correctly pointing to /etc/alternatives/nvidia. It would thus be nice, to not update symlinks

Bug#636700: update-alternatives: Don't update alternative symlinks if they are already correct

2011-08-16 Thread Raphael Hertzog
Hi Salvatore, On Tue, 16 Aug 2011, Salvatore Bonaccorso wrote: Attached is a tentative patch trying to solve this: a link should only be updated, if it does not point to the right place. Can you add a test-case for this? I guess that verifying that the inode number did not change is a good way

Bug#636700: update-alternatives: Don't update alternative symlinks if they are already correct

2011-08-05 Thread Salvatore Bonaccorso
Package: dpkg Version: 1.15.8.11 Severity: normal Hi The following situation causes a problem with version of update-alternatives in Squeeze, which worked in Lenny. Prerequisites: We have diskless Clients with read-only /usr and writable /etc. In /usr/lib there are packages installing