Package: libdecodeqr
Version: 0.9.3-5
Severity: important
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu oneiric ubuntu-patch

Hi there,

libdecodeqr fails to build with a linker that defaults to --as-needed,
as shown in the attached build log (from Ubuntu).

This is because of incorrect link ordering. Libraries must go after the
objects that use them.

  http://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries

The attached patch fixes this.

  * debian/patches/04_fix_ftbfs_618132.dpatch: Reorder library linking so that
    -lcv comes after -ldecodeqr which references it.

Thanks for considering the patch.

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.0.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) (ignored: LC_ALL 
set to en_GB.UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru libdecodeqr-0.9.3/debian/changelog libdecodeqr-0.9.3/debian/changelog
diff -Nru libdecodeqr-0.9.3/debian/patches/04_fix_ftbfs_618132.patch libdecodeqr-0.9.3/debian/patches/04_fix_ftbfs_618132.patch
--- libdecodeqr-0.9.3/debian/patches/04_fix_ftbfs_618132.patch	2011-09-13 02:34:40.000000000 +0100
+++ libdecodeqr-0.9.3/debian/patches/04_fix_ftbfs_618132.patch	2011-09-14 11:21:42.000000000 +0100
@@ -35,7 +35,7 @@
  LIBCV=@LIBCV@
  LIBHIGHGUI=@LIBHIGHGUI@
 -LIBS=$(LIBCV) $(LIBHIGHGUI) -ldecodeqr
-+LIBS=$(LIBCV) $(LIBHIGHGUI) -lcxcore -ldecodeqr
++LIBS=$(LIBHIGHGUI) -lcxcore -ldecodeqr $(LIBCV)
  
  LDFLAGS=@LDFLAGS@ -L$(LIBDECODEQR_DIR)
  
@@ -48,7 +48,7 @@
  LIBCV=@LIBCV@
  LIBHIGHGUI=@LIBHIGHGUI@
 -LIBS=$(LIBCV) $(LIBHIGHGUI) -ldecodeqr
-+LIBS=$(LIBCV) $(LIBHIGHGUI) -lcxcore -ldecodeqr
++LIBS=$(LIBHIGHGUI) -lcxcore -ldecodeqr $(LIBCV) 
  
  LDFLAGS=@LDFLAGS@ -L$(LIBDECODEQR_DIR)
  

Attachment: libdecodeqr_0.9.3-5-amd64-20110914-1042.gz
Description: GNU Zip compressed data

Reply via email to