Package: syslinux
Version: 2:4.04+dfsg-7
Severity: important
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch oneiric

syslinux fails to build with a linker that defaults to --as-needed, as
shown in this Ubuntu build log:

  
https://launchpadlibrarian.net/85113050/buildlog_ubuntu-precise-i386.syslinux_2%3A4.04%2Bdfsg-7_FAILEDTOBUILD.txt.gz

This is because of incorrect link ordering in the new isohybrid-gpt
patch: it puts libraries before the objects that use them rather than
after.  See:

  http://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries

The following patch fixes this.

  * Fix link order in 08-isohybrid-gpt.patch.

diff -Nru syslinux-4.04+dfsg/debian/patches/08-isohybrid-gpt.patch 
syslinux-4.04+dfsg/debian/patches/08-isohybrid-gpt.patch
--- syslinux-4.04+dfsg/debian/patches/08-isohybrid-gpt.patch    2011-11-02 
06:57:53.000000000 +0000
+++ syslinux-4.04+dfsg/debian/patches/08-isohybrid-gpt.patch    2011-11-14 
14:00:23.000000000 +0000
@@ -770,7 +770,7 @@
  
  isohybrid: isohybrid.o isohdpfx.o
 -      $(CC) $(LDFLAGS) -o $@ $^
-+      $(CC) $(LDFLAGS) -luuid -o $@ $^
++      $(CC) $(LDFLAGS) -o $@ $^ -luuid
  
  gethostip: gethostip.o
        $(CC) $(LDFLAGS) -o $@ $^

Thanks,

-- 
Colin Watson                                       [cjwat...@ubuntu.com]



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to