Bug#653968: [PATCH] gitolite: gl-setup doesn't warn it opens another editor (Emacs M-x shell)

2012-01-11 Thread jaalto
On 2012-01-11 03:31, Sitaram Chamarty wrote: | On Wed, Jan 11, 2012 at 12:12 AM, Jari Aalto jari.aa...@cante.net wrote: | retitle 653968 [PATCH] gitolite: gl-setup doesn't warn it opens another editor (Emacs M-x shell) | forwarded 653968 Sitaram Chamarty sitar...@gmail.com | thanks | |

Bug#653968: [PATCH] gitolite: gl-setup doesn't warn it opens another editor (Emacs M-x shell)

2012-01-11 Thread Sitaram Chamarty
On Wed, Jan 11, 2012 at 1:59 PM, jaalto jari.aa...@cante.net wrote: On 2012-01-11 03:31, Sitaram Chamarty wrote: | On Wed, Jan 11, 2012 at 12:12 AM, Jari Aalto jari.aa...@cante.net wrote: | retitle 653968 [PATCH] gitolite: gl-setup doesn't warn it opens another editor (Emacs M-x shell) |

Bug#653968: [PATCH] gitolite: gl-setup doesn't warn it opens another editor (Emacs M-x shell)

2012-01-11 Thread jaalto
On 2012-01-11 14:03, Sitaram Chamarty wrote: | On Wed, Jan 11, 2012 at 1:59 PM, jaalto jari.aa...@cante.net wrote: | On 2012-01-11 03:31, Sitaram Chamarty wrote: | |    http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=653968 | | | | Sorry but this does not make any sense to me. | | The

Bug#653968: [PATCH] gitolite: gl-setup doesn't warn it opens another editor (Emacs M-x shell)

2012-01-11 Thread Sitaram Chamarty
sigh On Wed, Jan 11, 2012 at 2:36 PM, jaalto jari.aa...@cante.net wrote: The current code makes assumptions about environment that are not necessarily true. Please just $EDITOR to whatever you want; vi is not the default; it's the fallback if $EDITOR is not set. I didn't invent $EDITOR; it's

Bug#653968: [PATCH] gitolite: gl-setup doesn't warn it opens another editor (Emacs M-x shell)

2012-01-11 Thread jaalto
On 2012-01-11 14:43, Sitaram Chamarty wrote: | The current code makes assumptions about environment that are not | necessarily true. | | Please just $EDITOR to whatever you want; vi is not the default; it's | the fallback if $EDITOR is not set. | | I didn't invent $EDITOR; it's apparently some

Bug#653968: [PATCH] gitolite: gl-setup doesn't warn it opens another editor (Emacs M-x shell)

2012-01-11 Thread Sitaram Chamarty
On Wed, Jan 11, 2012 at 3:39 PM, jaalto jari.aa...@cante.net wrote: Using EDITOR is standard thing. But this is not related to discussion where program makes assumptions about being run under controlling terminal. That's the first time you mentioned controlling terminal, i.e., more generic

Bug#653968: [PATCH] gitolite: gl-setup doesn't warn it opens another editor (Emacs M-x shell)

2012-01-11 Thread jaalto
On 2012-01-11 16:37, Sitaram Chamarty wrote: | Please check if 'test -t 0' is sufficient to test this and let me know. Under Emacs M-x shell: $ test -t 0 ; echo $? 0 Jari -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe.

Bug#653968: [PATCH] gitolite: gl-setup doesn't warn it opens another editor (Emacs M-x shell)

2012-01-11 Thread Sitaram Chamarty
On Wed, Jan 11, 2012 at 5:30 PM, jaalto jari.aa...@cante.net wrote: On 2012-01-11 16:37, Sitaram Chamarty wrote: | Please check if 'test -t 0' is sufficient to test this and let me know. Under Emacs M-x shell:      $ test -t 0 ;  echo $?      0 And I know under a normal shell also it says

Bug#653968: [PATCH] gitolite: gl-setup doesn't warn it opens another editor (Emacs M-x shell)

2012-01-11 Thread jaalto
On 2012-01-11 17:39, Sitaram Chamarty wrote: | | Well, try fd 1, and possibly fd 2 as well I guess. I'll also check | around for a way to detect not having a controlling terminal. Here are the results from Emacs M-x shell: $ for i in 0 1 2 ; do test -t $i ; echo fd $i status: $? ; done

Bug#653968: [PATCH] gitolite: gl-setup doesn't warn it opens another editor (Emacs M-x shell)

2012-01-10 Thread Jari Aalto
retitle 653968 [PATCH] gitolite: gl-setup doesn't warn it opens another editor (Emacs M-x shell) forwarded 653968 Sitaram Chamarty sitar...@gmail.com thanks Sitaram, could you apply this patch to fix Debian bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=653968 Thanks, Jari From

Bug#653968: [PATCH] gitolite: gl-setup doesn't warn it opens another editor (Emacs M-x shell)

2012-01-10 Thread Sitaram Chamarty
On Wed, Jan 11, 2012 at 12:12 AM, Jari Aalto jari.aa...@cante.net wrote: retitle 653968 [PATCH] gitolite: gl-setup doesn't warn it opens another editor (Emacs M-x shell) forwarded 653968 Sitaram Chamarty sitar...@gmail.com thanks Sitaram, could you apply this patch to fix Debian bug:    

Bug#653968: [PATCH] gitolite: gl-setup doesn't warn it opens another editor (Emacs M-x shell)

2012-01-10 Thread Sitaram Chamarty
However, I realise now that the -q was not documented. Sorry about that; the following documentation changes have now been pushed to both github and googlecode sites: https://github.com/sitaramc/gitolite/commit/c15ceeb3eb37666435499d3d7dcb144fbaa0990d (And although I believe an instruction to