Hi All,
As Wordpress no more depends on libphp-simplepie, I will downgrade
the priority to 'normal', ok?!
Cheers,
--
Marcelo Jorge Vieira
xmpp:me...@jabber-br.org
http://metaldot.alucinados.com
signature.asc
Description: This is a digitally signed message part
On Mon, 16 Apr 2012, Thorsten Glaser wrote:
As should be. My usecase here is FusionForge, and it too uses the
Debian packaged version. It also displays all those PHP warnings in
deliberately ugly pink overlays over the page, on development systems,
so that developers get a notion of them
Raphael Hertzog dixit:
What kind of warning does the use of static fix ?
The method is called only as class method, i.e.
$foo = SimplePie_Cache::create();
and not as instance method, which would be
$foo = new SimplePie_Cache;
$foo-create();
In any case, I agree those
Package: libphp-simplepie
Version: 1.2.1-3
Severity: important
The changes made in response to #651515 break WordPress. It's good to
clean up code but this should be upstream's responsibilities and deviating
from upstream can cause issues with external code using simplepie.
In this case,
Raphaël Hertzog dixit:
The code in question seems legitimate:
Actually, it is a good example for a class method, hence static.
class WP_Feed_Cache extends SimplePie_Cache {
/**
* Create a new SimplePie_Cache object
*
* @static
* @access public
On Mon, 16 Apr 2012, Thorsten Glaser wrote:
I’d rather insert a “static” here. I believe it was only not done
due to the simplepie bug, considering the @static annotation comment
above.
It's a possibility but I don't really like to have to maintain 2
divergences in Debian and as soon as
Raphael Hertzog dixit:
It's a possibility but I don't really like to have to maintain 2
divergences in Debian and as soon as someone grabs a clean upstream
version, they get it broken again. :-(
But that’s not supported.
At least Wordpress has its own copy of libphp-simplepie. The reason why
7 matches
Mail list logo
