Bug#681647: bindfs: Invalid memory access

2012-07-15 Thread Martin Pärtel
Thanks Marcelo. It's embarassing how many memory bugs I've put into bindfs recently. 1.10.7 should be clean (ran test suite with valgrind), but if you want to base off 1.10.3 due to a feature freeze or something, then please use the attached two patches instead. One is a more comprehensive

Bug#681647: bindfs: Invalid memory access

2012-07-15 Thread Eugene V. Lyubimkin
Hi Marcelo and Martin, Thank you for your messages and patches, On 2012-07-15 12:36, Martin Pärtel wrote: 1.10.7 should be clean (ran test suite with valgrind), but if you want to base off 1.10.3 due to a feature freeze or something, then please use the attached two patches instead. One is a

Bug#681647: bindfs: Invalid memory access

2012-07-15 Thread Marcelo E. Magallon
Hi Martin, thanks for the patches! About the readdir one, I saw that change in the newer releases, and even if I can see why it works, I'm not convinced it's correct. As you already know, FUSE sends something like /src in the path argument. When passing that to pathconf, if /src doesn't

Bug#681647: bindfs: Invalid memory access

2012-07-15 Thread Martin Pärtel
Note that I added process_path to the revised patch, it's not the same code that was in 1.10.6. In 1.10.6 pathconf still failed for exactly the reason you described, but defaulting to NAME_MAX always saved the day. I feel quite stupid for staring at it for so long and not seeing the missing

Bug#681647: bindfs: Invalid memory access

2012-07-15 Thread Marcelo E. Magallon
Hi Martin, On Sun, Jul 15, 2012 at 04:21:23PM +0300, Martin Pärtel wrote: I feel quite stupid for staring at it for so long and not seeing the missing process_path :) We are on the same boat, as I managed to miss the call to process_path in your patch :-) Thanks! Marcelo -- To

Bug#681647: bindfs: Invalid memory access

2012-07-14 Thread Marcelo E. Magallon
Package: bindfs Version: 1.10.3-1.1 Severity: grave Tags: upstream patch Justification: renders package unusable Hi, please see attached patch. Upstream implemented a different fix in 1.10.4 and later. I don't think this renders the package unusable for every user or in every case, but it