Bug#683120: RFS: yadifa/1.0.3-1 [ITP]

2015-08-15 Thread Jakub Wilk
* Christian Kastner , 2014-04-09, 20:50: The Vcs-Git URL should use the git:// protocol specifier, and you could add a Vcs-Browser URL pointing to the github package, like so: -Vcs-Git: https://github.com/asciiprod/yadifa.git +Vcs-Git: git://github.com/asciiprod/yadifa.git The original URL

Bug#683120: RFS: yadifa/1.0.3-1 [ITP]

2014-04-11 Thread Markus Schade
On 04/09/2014 09:00 PM, Christian Kastner wrote: > Oh, I missed something here: you are using the substitution variable > ${Description}, but you are not setting it anywhere, which results in > half-empty descriptions (see the output in > debian/libdns*/DEBIAN/control). See deb-substvars(5). Agai

Bug#683120: RFS: yadifa/1.0.3-1 [ITP]

2014-04-09 Thread Christian Kastner
On 2014-04-09 20:50, Christian Kastner wrote: >>> debian/control >>> == > > I like your approach with a common description provided through a > substitution variable! Very efficient. Oh, I missed something here: you are using the substitution variable ${Description}, but you are not s

Bug#683120: RFS: yadifa/1.0.3-1 [ITP]

2014-04-09 Thread Christian Kastner
On 2014-04-09 09:26, Markus Schade wrote: > thanks for the review, Christian! Glad I can help :-) Here is some further feedback: >> debian/control >> == >> If you're using a VCS for your packaging, Vcs-* URLs would be nice (to >> simplify contributing to your packaging). You can als

Bug#683120: RFS: yadifa/1.0.3-1 [ITP]

2014-04-09 Thread Markus Schade
Hi, thanks for the review, Christian! On 04/05/2014 06:16 PM, Christian Kastner wrote: > AFAIK bind9 only stores run-time data in /var/cache/bind (from dynamic > DNS updates, etc). bind9's zone files are in /etc/bind/zones. > > [...] > > I'd either go with /etc/yadifa or /var/lib/yadifa. Check

Bug#683120: RFS: yadifa/1.0.3-1 [ITP]

2014-04-05 Thread Christian Kastner
Hi, On 2014-03-18 22:34, Markus Schade wrote:> However there is one question, which I am not sure, what is correct. > Upstream uses /var/zones as base for its zone files. My guess was > that this is not the proper location for such files in Debian. So I > changed it to /var/cache/yadifa like bind9

Bug#683120: RFS: yadifa/1.0.3-1 [ITP]

2014-03-18 Thread Markus Schade
Dear mentors, I have made some corrections/improvements and re-uploaded the package again. However there is one question, which I am not sure, what is correct. Upstream uses /var/zones as base for its zone files. My guess was that this is not the proper location for such files in Debian. So I cha