reassign 698629 libfm-gtk1 severity 698629 important tag 698629 patch forwarded 698629 http://sourceforge.net/tracker/?func=detail&aid=3496591&group_id=156956&atid=801864 thanks
Hello, I have found the solution for the drag n' drop issue with pcmanfm. Unfortunately the bug can neither be fixed nor really mitigated in xarchiver. The bug originates in libfm-gtk1 and has already been fixed by upstream on 2012-06-10. Bug report: http://sourceforge.net/tracker/?func=detail&aid=3496591&group_id=156956&atid=801864 Fix: http://pcmanfm.git.sourceforge.net/git/gitweb.cgi?p=pcmanfm/libfm;a=commit;h=97df3cb809a7398fd99eafcca9dae57b5615a470 I have reassigned bug 698629 to libfm-gtk1 accordingly and closing 688631. I'm also attaching the patch to this bug report. Regards, Markus
X-Git-Url: http://pcmanfm.git.sourceforge.net/git/gitweb.cgi?p=pcmanfm%2Flibfm;a=blobdiff_plain;f=src%2Fgtk%2Ffm-dnd-dest.c;h=f0de24ab381ace1ec352b97ab6ece4f285e65659;hp=acd19db661c37b4f1acdbe77195ba1d03b1abc88;hb=97df3cb809a7398fd99eafcca9dae57b5615a470;hpb=9fe672c5ee334c9333da736efa8a38ce1a7a377f diff --git a/src/gtk/fm-dnd-dest.c b/src/gtk/fm-dnd-dest.c index acd19db..f0de24a 100644 --- a/src/gtk/fm-dnd-dest.c +++ b/src/gtk/fm-dnd-dest.c @@ -444,6 +444,13 @@ GdkDragAction fm_dnd_dest_get_default_action(FmDndDest* dd, FmFileInfo* dest = dd->dest_file; FmPath* dest_path; + if(!dest || !(dest_path = fm_file_info_get_path(dest))) + return 0; + + /* this is XDirectSave */ + if(target == xds_target_atom) + return GDK_ACTION_COPY; + if(!dd->src_files) /* we didn't have any data, cache it */ { action = 0; @@ -455,13 +462,6 @@ GdkDragAction fm_dnd_dest_get_default_action(FmDndDest* dd, } } - if(!dest || !(dest_path = fm_file_info_get_path(dest))) - return FALSE; - - /* this is XDirectSave */ - if(target == xds_target_atom) - return GDK_ACTION_COPY; - if(dd->src_files) /* we have got drag source files */ { if(fm_path_is_trash(dest_path))
signature.asc
Description: Digital signature
