Bug#704252: preparing the fix

2013-04-15 Thread Abou Al Montacir
On Fri, 2013-04-12 at 22:48 +0200, Paul Gevers wrote: 1) You used dpkg-architecture -qDEB_BUILD_ARCH instead of dpkg-architecture -qDEB_BUILD_GNU_CPU (you could simplify your rules file as well with this). Hmm, it seems like this was not a smart idea for i386. So the point is that either

Bug#704252: preparing the fix

2013-04-15 Thread Abou Al Montacir
On Sun, 2013-04-14 at 08:34 +0200, Paul Gevers wrote: On 14-04-13 01:45, peter green wrote: Sorry I could have been clearer in my last mail. I didn't intend to blame you for most of the issues with the patch (you just took a broken patch and made it differently broken) but I could see how

Bug#704252: preparing the fix

2013-04-14 Thread Paul Gevers
On 14-04-13 01:45, peter green wrote: Sorry I could have been clearer in my last mail. I didn't intend to blame you for most of the issues with the patch (you just took a broken patch and made it differently broken) but I could see how it could have come across that way. Thanks for the

Bug#704252: preparing the fix

2013-04-14 Thread peter green
Paul Gevers wrote: Please go ahead. Lets get rid of this RC bug in Wheezy ASAP, so we can release. If I can help by filing and tracking the unblock after successful build (or I can even do the (unchanged :) ) upload for you), please let me know (here or in private) I just uploaded, feel free to

Bug#704252: preparing the fix

2013-04-13 Thread Paul Gevers
Peter, Please calm down. 1) I made a small change to the what Abou proposed, because his script did not work on my system (amd64) so most issues you mention are actually proposed by Abou. I think, but he can speak for himself, that he wanted more or less the same as in Lazarus. Actually, I

Bug#704252: preparing the fix

2013-04-13 Thread peter green
Paul Gevers wrote: Peter, Please calm down. Sorry I could have been clearer in my last mail. I didn't intend to blame you for most of the issues with the patch (you just took a broken patch and made it differently broken) but I could see how it could have come across that way. Still I firmly

Bug#704252: preparing the fix

2013-04-12 Thread Paul Gevers
Hi Abou, On 11-04-13 00:17, Abou Al Montacir wrote: Can you please take 2.6.0 branch head and upload. The other 2 items are just a typo in translation file and a fix suggested by release team themselves. I think we really conform to the freeze goals. However if you don't like these two fixes,

Bug#704252: preparing the fix

2013-04-12 Thread Paul Gevers
1) You used dpkg-architecture -qDEB_BUILD_ARCH instead of dpkg-architecture -qDEB_BUILD_GNU_CPU (you could simplify your rules file as well with this). Hmm, it seems like this was not a smart idea for i386. So the point is that either we have to fix i486 to i386 or amd64 to x86_64... Abou,

Bug#704252: preparing the fix

2013-04-12 Thread peter green
Paul Gevers wrote: I just uploaded with the patch for bug 704252. I didn't feel the other two items appropriate at this moment. It took me some more time than expected, because I had to fix two bugs in your script: So you are saying that rather rather than sponsoring abou's upload you made

Bug#704252: preparing the fix

2013-04-10 Thread Paul Gevers
tags 704252 +patch pending thanks On 10-04-13 22:45, Abou Al Montacir wrote: I've already committed this on svn on branch 2.6.0. I saw this after I sent the mail. I'm attaching patches for info. If you agree I can upload to mentors. The RT agrees with the patch for this issue. I have not

Bug#704252: preparing the fix

2013-04-10 Thread Abou Al Montacir
On Wed, 2013-04-10 at 23:20 +0200, Paul Gevers wrote: The RT agrees with the patch for this issue. I have not discussed the other items as I think they are not in line with the current freeze exceptions. I can create an upload tomorrow evening. If you want you can prepare that, via mentors,