Source: emacs24 Version: 24.3+1-1 Severity: important Tags: patch User: debian-h...@lists.debian.org Usertags: hurd
Hi, currently [1] emacs24 24.3 does not compile on GNU/Hurd. The problem is that, since Hurd's sys/param.h defines BSD (for some kind of BSD compatibility), BSD_SYSTEM is defined too, leading to the inclusion of sys/sysctl.h, which does not exist on Hurd. The problem has been (indirectly) fixed with upstream's r112030 [2] in trunk; attached there is a backport of this commit, which allows to successfully build emacs24 on Hurd. [1] https://buildd.debian.org/status/fetch.php?pkg=emacs24&arch=hurd-i386&ver=24.3%2B1-2&stamp=1380607262 [2] http://bzr.savannah.gnu.org/lh/emacs/trunk/revision/112030 Thanks, -- Pino
2013-03-13 Paul Eggert <egg...@cs.ucla.edu> * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out. Include <sys/param.h> unconditionally, as that works elsewhere and is simpler here. Include <sys/sysctl.h> if DARWIN_OS || __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin and FreeBSD now. --- a/src/sysdep.c 2013-03-06 08:01:47 +0000 +++ b/src/sysdep.c 2013-03-13 05:04:46 +0000 @@ -38,9 +38,8 @@ #include "sysselect.h" #include "blockinput.h" -#ifdef BSD_SYSTEM -#include <sys/param.h> -#include <sys/sysctl.h> +#if defined DARWIN_OS || defined __FreeBSD__ +# include <sys/sysctl.h> #endif #ifdef __FreeBSD__ @@ -69,9 +68,9 @@ #ifdef MSDOS /* Demacs 1.1.2 91/10/20 Manabu Higashida, MW Aug 1993 */ #include "msdos.h" -#include <sys/param.h> #endif +#include <sys/param.h> #include <sys/file.h> #include <fcntl.h>
