Package: sendip
Severity: minor
Tags: patch
Usertags: clang-ftbfs
Dear Maintainer,
Your package fails to build with clang instead of gcc.
The attached patch fixes it.
Best regards,
Alexander
-- System Information:
Debian Release: jessie/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 3.13-1-amd64 (SMP w/3 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
--- sendip-2.5/rip.c 2002-11-24 13:02:17.000000000 -0500
+++ sendip-2.5-my/rip.c 2014-03-16 08:09:40.356366665 -0400
@@ -61,19 +61,19 @@
ripopt = RIP_OPTION(pack);
p=q=arg;
/* TODO: if arg is malformed, this could segfault */
- while(*(q++)!=':') /* do nothing */; *(--q)='\0';
+ while(*(q++)!=':') {} /* do nothing */; *(--q)='\0';
rippack->addressFamily= htons((p==q)?2:(u_int16_t)strtoul(p, (char **)0, 0));
pack->modified |= RIP_MOD_ADDRFAM;
- p=++q; while(*(q++)!=':') /* do nothing */; *(--q)='\0';
+ p=++q; while(*(q++)!=':') {} /* do nothing */; *(--q)='\0';
rippack->routeTagOrAuthenticationType=htons((p==q)?0:(u_int16_t)strtoul(p, (char **)0,0));
pack->modified |= RIP_MOD_ROUTETAG;
- p=++q; while(*(q++)!=':') /* do nothing */; *(--q)='\0';
+ p=++q; while(*(q++)!=':') {} /* do nothing */; *(--q)='\0';
ripopt->address=(p==q)?inet_addr("0.0.0.0"):inet_addr(p);
- p=++q; while(*(q++)!=':') /* do nothing */; *(--q)='\0';
+ p=++q; while(*(q++)!=':') {} /* do nothing */; *(--q)='\0';
ripopt->subnetMask=(p==q)?inet_addr("255.255.255.0"):inet_addr(p);
- p=++q; while(*(q++)!=':') /* do nothing */; *(--q)='\0';
+ p=++q; while(*(q++)!=':') {} /* do nothing */; *(--q)='\0';
ripopt->nextHop=(p==q)?inet_addr("0.0.0.0"):inet_addr(p);
- p=++q; while(*(q++)!='\0') /* do nothing */; *(--q)='\0';
+ p=++q; while(*(q++)!='\0') {} /* do nothing */; *(--q)='\0';
ripopt->metric=htonl((p==q)?16:(u_int32_t)strtoul(p,(char **)0, 0));
break;
case 'd': /* default request */
--- sendip-2.5/ripng.c 2002-11-24 13:02:17.000000000 -0500
+++ sendip-2.5-my/ripng.c 2014-03-16 08:09:39.004406945 -0400
@@ -77,16 +77,16 @@
ripopt = RIPNG_ENTRY(pack);
p=q=arg;
/* TODO: if arg is malformed, this could segfault */
- while(*(q++)!='/') /* do nothing */; *(--q)='\0';
+ while(*(q++)!='/') {} /* do nothing */; *(--q)='\0';
ripopt->prefix = (p==q)?in6addr_any:inet6_addr(p);
- p=++q; while(*(q++)!='/') /* do nothing */; *(--q)='\0';
+ p=++q; while(*(q++)!='/') {} /* do nothing */; *(--q)='\0';
ripopt->tag=htons( (p==q)?0:(u_int16_t)strtoul(p, (char **)0,0));
- p=++q; while(*(q++)!='/') /* do nothing */; *(--q)='\0';
+ p=++q; while(*(q++)!='/') {} /* do nothing */; *(--q)='\0';
ripopt->len=(p==q)?(u_int8_t)128:(u_int8_t)strtoul(p, (char **)0,0);
- p=++q; while(*(q++)!='\0') /* do nothing */; *(--q)='\0';
+ p=++q; while(*(q++)!='\0') {} /* do nothing */; *(--q)='\0';
ripopt->metric=(p==q)?(u_int8_t)16:(u_int8_t)strtoul(p,(char **)0, 0);
break;
case 'd': /* default request */
