Bug#743576: Patch for #743576 (but not, #743617 or #705967)

2014-09-10 Thread Joey Hess
martin f krafft wrote: > Previously, the CWD was just left at the top-level, right? > Therefore, I assume that the commands all already took precautions > to ensure that they operate on the right subdir, e.g. by setting > GIT_DIR. No, mr chdirs before running lots of stuff. And doesn't chdir befor

Bug#743576: Patch for #743576 (but not, #743617 or #705967)

2014-09-09 Thread martin f krafft
also sprach Joey Hess [2014-09-10 02:42 +0200]: > mr runs all kinds of external commands. How does changing the CWD > and leaving it changed not affect them? Previously, the CWD was just left at the top-level, right? Therefore, I assume that the commands all already took precautions to ensure tha

Bug#743576: Patch for #743576 (but not, #743617 or #705967)

2014-09-09 Thread Joey Hess
martin f krafft wrote: > also sprach Joey Hess [2014-09-09 20:43 +0200]: > > This seems to chdir and then not chdir back. How does it avoid > > breaking existing setups? > > I intentionally did it this way, because I could not see a way in > which this would actually matter, given that CWD doesn'

Bug#743576: Patch for #743576 (but not, #743617 or #705967)

2014-09-09 Thread martin f krafft
also sprach Joey Hess [2014-09-09 20:43 +0200]: > This seems to chdir and then not chdir back. How does it avoid > breaking existing setups? I intentionally did it this way, because I could not see a way in which this would actually matter, given that CWD doesn't play a role at the moment. > > T

Bug#743576: Patch for #743576 (but not, #743617 or #705967)

2014-09-09 Thread Joey Hess
martin f krafft wrote: > Make mr try to chdir() to the dirname() of any .mrconfig files it's > supposed to load. If the chdir() is successful, then the filename is > truncated to basename(). If the chdir() is unsuccessful, then processing > happens as before. This seems to chdir and then not chdir

Bug#743576: Patch for #743576 (but not, #743617 or #705967)

2014-09-09 Thread martin f krafft
tags 743576 patch thanks Hopefully the last message to this bug report. While I have not been able to tackle #743617, I think that the two attached patches fix #743576. Also, I unmerged #705967, because I don't think #743576 is the solution here. Instead, I think we should introduce proper variab