Bug#756843: open-iscsi: 7e1ae42 patch only mounting first target disk, then always failing in the end even on success

2014-08-03 Thread Ritesh Raj Sarraf
On 08/02/2014 11:08 PM, Turbo Fredriksson wrote: How about this change? Torben, could you test? I choose to use your 'temporary file' solution. Seemed simplest. I don't like it much. It is too much of unwanted work for something which could have been done more simply in the first place.

Bug#756843: open-iscsi: 7e1ae42 patch only mounting first target disk, then always failing in the end even on success

2014-08-03 Thread Turbo Fredriksson
On Aug 3, 2014, at 10:16 AM, Ritesh Raj Sarraf wrote: I will soon, for the next upload, revert these changes, and move back to the old solution of (mount -a + swapon -a). Is that okay with you guys ??? Not to me, not really! Your previous way didn't work at all for me, this works for

Bug#756843: open-iscsi: 7e1ae42 patch only mounting first target disk, then always failing in the end even on success

2014-08-03 Thread Ritesh Raj Sarraf
On 08/03/2014 05:26 PM, Turbo Fredriksson wrote: On Aug 3, 2014, at 10:16 AM, Ritesh Raj Sarraf wrote: I will soon, for the next upload, revert these changes, and move back to the old solution of (mount -a + swapon -a). Is that okay with you guys ??? Not to me, not really! Your previous

Bug#756843: open-iscsi: 7e1ae42 patch only mounting first target disk, then always failing in the end even on success

2014-08-03 Thread Torben Frey
For me it seems the older slightly extended short version is doing all tasks including adding the swap devices. Just the explicit fsck would be missing, but is it necessary anyways? I would also give the short version including swapon a thumbs up! On Aug 3, 2014, at 2:38 PM, Ritesh Raj Sarraf

Bug#756843: open-iscsi: 7e1ae42 patch only mounting first target disk, then always failing in the end even on success

2014-08-03 Thread Turbo Fredriksson
On Aug 3, 2014, at 2:38 PM, Ritesh Raj Sarraf wrote: Why ?? It should work. Your previous bug report was about swap devices not being handled. With its inclusion, why will it not work ? 1. Because there's no fsck before mounting the filesystem. That's really ugly, and potentially

Bug#756843: open-iscsi: 7e1ae42 patch only mounting first target disk, then always failing in the end even on success

2014-08-03 Thread Ritesh Raj Sarraf
On 08/03/2014 07:40 PM, Turbo Fredriksson wrote: 1. Because there's no fsck before mounting the filesystem. That's really ugly, and potentially dangerous. Yes, it will simply fail if the fs is dirty, but I'm sure there's occasions where mount doesn't discover everything and a

Bug#756843: open-iscsi: 7e1ae42 patch only mounting first target disk, then always failing in the end even on success

2014-08-02 Thread Torben Frey
Package: open-iscsi Version: 2.0.873+git0.3b4b4500-2 Severity: important Dear Ritesh and Turbo, this new patch is causing trouble for two reasons. Here are the relevant lines from patch 7e1ae42: + while read fs; do + set -- $(eval echo $fs | sed 's@:@ @') +

Bug#756843: open-iscsi: 7e1ae42 patch only mounting first target disk, then always failing in the end even on success

2014-08-02 Thread Ritesh Raj Sarraf
Thank you for the bug report Torben. Sigh!! I think that whole patch was buggy. I don't see the $fs variable ever having been initialized. Was it ?? My bad. :-( @Turbo: Do you have an opinion here? I am inclined to reverting that patch completely. Let me know. On 08/02/2014 06:23 PM, Torben

Bug#756843: open-iscsi: 7e1ae42 patch only mounting first target disk, then always failing in the end even on success

2014-08-02 Thread Torben Frey
Hi Ritesh, oh yes, the fs variable is initialized before the loops are starting, together with the MOUNT_RESULT: # Now let's mount log_daemon_msg Mounting network filesystems MOUNT_RESULT=1 fs= And I guess functionality is good after removing the “break”

Bug#756843: open-iscsi: 7e1ae42 patch only mounting first target disk, then always failing in the end even on success

2014-08-02 Thread Turbo Fredriksson
On Aug 2, 2014, at 3:58 PM, Torben Frey wrote: And I guess functionality is good after removing the “break” command. I just tested this with multiple _netdev entries, and they all work! So I couldn't reproduce this problem. I just don’t exactly know how the MOUNT_RESULT could summarize the

Bug#756843: open-iscsi: 7e1ae42 patch only mounting first target disk, then always failing in the end even on success

2014-08-02 Thread Turbo Fredriksson
How about this change? Torben, could you test? I choose to use your 'temporary file' solution. Seemed simplest. open-iscsi.init.diff Description: Binary data

Bug#756843: open-iscsi: 7e1ae42 patch only mounting first target disk, then always failing in the end even on success

2014-08-02 Thread Torben Frey
Hey Turbo, And I guess functionality is good after removing the “break” command. I just tested this with multiple _netdev entries, and they all work! So I couldn't reproduce this problem. I have tried once more and with the break command it is always stopping after the first mount, be it

Bug#756843: open-iscsi: 7e1ae42 patch only mounting first target disk, then always failing in the end even on success

2014-08-02 Thread Torben Frey
Hey again, Turbo! How about this change? Torben, could you test? I choose to use your 'temporary file' solution. Seemed simplest. I have patched the original init script with your new patch - and it is working flawlessly for me. When all my 4 fstab entries are correct and mountable, I am

Bug#756843: open-iscsi: 7e1ae42 patch only mounting first target disk, then always failing in the end even on success

2014-08-02 Thread Turbo Fredriksson
On Aug 2, 2014, at 10:56 PM, Torben Frey wrote: Working perfectly for me now. Thanks for the quick fix and patch! Sounds good and you're most welcome! Ritesh, mind applying it to the next package version? Btw, you can close https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=688209, because

Bug#756843: open-iscsi: 7e1ae42 patch only mounting first target disk, then always failing in the end even on success

2014-08-02 Thread Torben Frey
Hey Turbo, I have tried once more and with the break command it is always stopping after the first mount, be it successful or not. Removing the break is mounting all 4 devices in my stab. Weird! May I ask what your fstab entries look like (exactly)? Thanks a lot, I will send the other