Bug#770162: htslib: fai_build_core in faidx.c assumes char is signed

2014-12-14 Thread Andreas Tille
Hi Edmund, thanks for this helpful bug report. I have commited patches in jessie branch. Charles, I'm not sure how you want to deal with this. I'd regard the issue RC and it should be uploaded. However, I'm not really sure how you want to deal with the git repository and thus I simply

Bug#770162: htslib: fai_build_core in faidx.c assumes char is signed

2014-12-14 Thread Charles Plessy
Le Sun, Dec 14, 2014 at 09:22:44AM +0100, Andreas Tille a écrit : Charles, I'm not sure how you want to deal with this. I'd regard the issue RC and it should be uploaded. However, I'm not really sure how you want to deal with the git repository and thus I simply commited the new branch and

Bug#770162: htslib: fai_build_core in faidx.c assumes char is signed

2014-12-14 Thread Andreas Tille
Hi Charles, On Mon, Dec 15, 2014 at 03:34:09AM +0900, Charles Plessy wrote: on my side, since in Jessie we still have the old SAMtools, and since most NGS applications using the libbam have not been migrated to the HTSlib, I would not consider portability issues RC for Jessie. This would

Bug#770162: htslib: fai_build_core in faidx.c assumes char is signed

2014-12-12 Thread John Marshall
This has been fixed upstream, in https://github.com/samtools/htslib/commit/14a4a81f67a122f7bb2e87e5fa070aa270b0aec5 Thanks, John -- The Wellcome Trust Sanger Institute is operated by Genome Research Limited, a charity registered in England with number 1021457 and a company registered in

Bug#770162: htslib: fai_build_core in faidx.c assumes char is signed

2014-11-19 Thread Edmund Grimley Evans
Source: htslib Version: 1.1-1 The code looks like this: faidx_t *fai_build_core(BGZF *bgzf) { char c, *name; ... while ( (c=bgzf_getc(bgzf))=0 ) { Clearly on architectures where plain char is unsigned (arm64, armhf, ...) this won't work (infinite loop). I'd suggest changing the type of