Package: nm.debian.org Severity: minor Tags: patch Hi
I am a DM. My application process is in state "AM approved". When I go to https://nm.debian.org/am/person/nirgal I have this message > Jean-Michel Vourgère already has an LDAP record (finger > nir...@db.debian.org), so their name, uid and email cannot be changed > here. The email address can be changed using the db.debian.org LDAP > Gateway. I do not have an account yet, so I expected another message. restricted/templates/restricted/person.html does test > if "edit_ldap" not in vperms.perms but backend.models.PersonVisitorPermissions._can_edit_ldap_fields returns False when visitor is not admin and progress==PROGRESS_AM_OK. Attached is a proposal of an alternative message. Cheers -- Nirgal
diff --git a/restricted/templates/restricted/person.html b/restricted/templates/restricted/person.html index b8e4796..b2b0ec0 100644 --- a/restricted/templates/restricted/person.html +++ b/restricted/templates/restricted/person.html @@ -24,10 +24,14 @@ {% if "edit_ldap" not in vperms.perms %} <p> -{{person.fullname}} already has an LDAP record (<tt>finger -{{person.uid}}@db.debian.org</tt>), so their name, uid and email cannot be -changed here. The email address can be changed using the -<a href="https://db.debian.org/doc-mail.html">db.debian.org LDAP Gateway</a>. +Name, uid and email cannot be changed here:<br> +Either {{person.fullname}} already has an LDAP record (<tt>finger +{{person.uid}}@db.debian.org</tt>): In that case the email address can be +changed using the +<a href="https://db.debian.org/doc-mail.html">db.debian.org LDAP Gateway</a>; +<br> +Or {{person.fullname}} application progress is past the point where you are +allowed to change these data from here. </p> {% endif %}
signature.asc
Description: OpenPGP digital signature