Bug#785333: [Pkg-roundcube-maintainers] Bug#785333: broken contextmenu due to jquery

2015-06-12 Thread Holger Levsen
Hi Craig, On Freitag, 5. Juni 2015, Craig Small wrote: I'm the Debian maintainer for wordpress. It seems that there might be similar problems with roundcube and wordpress and jquery. I'm mereley a roundcube user here :) And a DD (well aware why embedding source code is bad in general)

Bug#785333: [Pkg-roundcube-maintainers] Bug#785333: broken contextmenu due to jquery

2015-06-05 Thread Craig Small
Hi, I'm the Debian maintainer for wordpress. It seems that there might be similar problems with roundcube and wordpress and jquery. The short answer is that if you are not too careful mixing jquery and other js modules together in a random way will mean stuff breaks. Javascript isn't as

Bug#785333: [Pkg-roundcube-maintainers] Bug#785333: broken contextmenu due to jquery

2015-06-05 Thread Vincent Bernat
❦ 5 juin 2015 22:10 +1000, Craig Small csm...@debian.org : The must ship non-minified sources is a tad annoying but for me I generally do this. They have to be there but generally I don't build off them. If the bug is bad enough I'd probably directly edit the minified file anyhow. You

Bug#785333: [Pkg-roundcube-maintainers] Bug#785333: broken contextmenu due to jquery

2015-06-04 Thread Sandro Knauß
Hey, Keep in mind, that Debian only say, that there must be the source code available at building time. For javascript this means, that an unminified version should be availabe in the source. Javascript is minified by building the package, because this makes sense in termes of performance.

Bug#785333: [Pkg-roundcube-maintainers] Bug#785333: broken contextmenu due to jquery

2015-06-04 Thread Stefan Hornburg (Racke)
On 06/04/2015 09:16 AM, Sandro Knauß wrote: Hey, Keep in mind, that Debian only say, that there must be the source code available at building time. For javascript this means, that an unminified version should be availabe in the source. Javascript is minified by building the package,

Bug#785333: broken contextmenu due to jquery

2015-06-03 Thread Holger Levsen
Hi, On Donnerstag, 4. Juni 2015, Kurt Fitzner wrote: Waitaminnit... what do you mean build??? jquery.min.js, the file in question, is JavaScript. One simply includes the javascript source in RoundCube, as it is provided. It's not an applet. There is no building, there are no sources or

Bug#785333: broken contextmenu due to jquery

2015-06-03 Thread Kurt Fitzner
On 03/06/2015 2:36 AM, Vincent Bernat wrote: Unfortunately, Debian has a strong policy against embedding dependencies. Therefore, we cannot embed jquery and we cannot embed tinymce. Obviously it's not as strong as one might think, since Wordpress manages to embed tinymce in its packages. As

Bug#785333: broken contextmenu due to jquery

2015-06-03 Thread Kurt Fitzner
On 03/06/2015 9:20 PM, Holger Levsen wrote: minified javascript is (clearly) not the prefered form of modification, Wow. Just wow. Un-pretty-printing a script makes it a binary. That's a whole new level of, I'll call it dedication, to the letter of the law. I applaud the committee that came

Bug#785333: broken contextmenu due to jquery

2015-06-02 Thread Kurt Fitzner
The old jquery linked to in RoundCube also breaks plugins like contextmenu. The better fix for Debian's RoundCube is not to update the jquery package to its new upstream, but to include with RoundCube the appropriate version of jquery supplied from its own upstream. jquery, like tinymce, is

Bug#785333: broken contextmenu due to jquery

2015-06-02 Thread Vincent Bernat
❦ 2 juin 2015 22:10 -0300, Kurt Fitzner k...@va1der.ca : Far too much thought is being put into a very simple problem. Namely that too many of the included files from the upstream RoundCube distribution are being removed from the distribution in favour of inappropriately trying to link