Bug#793939: [RFR] templates://publicfile-installer/{templates}

2015-09-12 Thread Justin B Rye
Justin B Rye wrote: > Unfortunately, fixing it probably requires changes to the visible > behaviour of the scripts that would mean changes to these debconf > prompts, so we'll need to put this review on hold. Ah - looks like the bug has been fixed:

Bug#793939: [RFR] templates://publicfile-installer/{templates}

2015-08-09 Thread Christian PERRIER
Quoting Justin B Rye (justin.byam@gmail.com): But why does it need a special script to install a package? (Goes and looks...) Yipe! It just checks I'm root and then runs dpkg -i /tmp/publicfile-installer/publicfile*_*.deb Does the build really leave its output in a predictable

Bug#793939: [RFR] templates://publicfile-installer/{templates}

2015-08-09 Thread Justin B Rye
Christian PERRIER wrote: Quoting Justin B Rye (justin.byam@gmail.com): But why does it need a special script to install a package? (Goes and looks...) Yipe! It just checks I'm root and then runs dpkg -i /tmp/publicfile-installer/publicfile*_*.deb Does the build really leave its

Bug#793939: [RFR] templates://publicfile-installer/{templates}

2015-08-08 Thread Christian PERRIER
Please find, for review, the debconf templates and packages descriptions for the publicfile-installer source package. This review will last from Saturday, August 08, 2015 to Tuesday, August 18, 2015. Please send reviews as unified diffs (diff -u) against the original files. Comments about your

Bug#793939: [RFR] templates://publicfile-installer/{templates}

2015-08-08 Thread Justin B Rye
Christian PERRIER wrote: Rationale: --- publicfile-installer.old/debian/templates 2015-07-29 08:21:48.490182705 +0200 +++ publicfile-installer/debian/templates 2015-07-29 13:44:58.140605903 +0200 @@ -1,13 +1,16 @@ Template: publicfile-installer/build Type: boolean Default: false