Source: oldsys-preseed
Version: 3.18
Severity: serious
Tags: patch
Justification: fails to build from source

Dear Maintainer,

oldsys-preseed fails to build from source on unstable/amd64 under some
locales (eg. LANG=fr_CH.UTF-8):

  [..]

  Running test arm/nslu2_invalid_hostname... ok
  Running test arm/nslu2_static_no_dns... ---
  arm/nslu2_static_no_dns.preseed     2011-05-05 10:29:52.000000000
  +1400
  +++ /tmp/fileSlf9om     2015-07-24 04:40:44.883126572 +1400
  @@ -3,7 +3,7 @@
   d-i netcfg/get_ipaddress string 192.168.1.77
   d-i netcfg/get_netmask string 255.255.255.0
   d-i netcfg/get_gateway string 192.168.1.1
  -d-i netcfg/get_nameservers string 192.168.1.1
  +d-i netcfg/get_nameservers string Binary file (standard input)
  matches Binary file (standard input) matches Binary file (standard
  input) matches
   d-i netcfg/choose_interface select eth0
   d-i netcfg/use_dhcp boolean true
  -d-i netcfg/get_hostname string foobar
  +d-i netcfg/get_domain string Binary file (standard input) matches
  not ok
  Running test arm/nslu2_static_no_gw... ok
  Running test arm/nslu2_static_no_ip... ---
  arm/nslu2_static_no_ip.preseed       2011-05-05 10:29:52.000000000
  +1400
  +++ /tmp/fileAZzknD     2015-07-24 04:40:45.407118543 +1400
  @@ -3,7 +3,7 @@
   d-i netcfg/get_ipaddress string 192.168.1.77
   d-i netcfg/get_netmask string 255.255.255.0
   d-i netcfg/get_gateway string 192.168.1.1
  -d-i netcfg/get_nameservers string 213.33.99.70
  +d-i netcfg/get_nameservers string Binary file (standard input)
  matches Binary file (standard input) matches Binary file (standard
  input) matches
   d-i netcfg/choose_interface select eth0
   d-i netcfg/use_dhcp boolean true
  -d-i netcfg/get_hostname string foobar
  +d-i netcfg/get_domain string Binary file (standard input) matches
  not ok
  Running test arm/nslu2_static... ok

  [..]

  debian/rules:11: recipe for target 'override_dh_auto_test' failed
  make[1]: *** [override_dh_auto_test] Error 1
  make[1]: Leaving directory '/tmp/buildd/oldsys-preseed-3.18'
  debian/rules:3: recipe for target 'build' failed
  make: *** [build] Error 2
  dpkg-buildpackage: error: debian/rules build gave error exit status 2

  [..]

The full build log is attached or can be viewed here:

  
https://reproducible.debian.net/logs/unstable/amd64/oldsys-preseed_3.18.build2.log.gz

This is because of grep's automagic locale detection. Patch attached.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      la...@debian.org / chris-lamb.co.uk
       `-
diff --git a/functions b/functions
index a3a7d90..f770ab1 100644
--- a/functions
+++ b/functions
@@ -103,7 +103,7 @@ parse_ifconfig() {
 # $1 = string
 # $2 = var
 get_var() {
-       echo "$1" | grep "^$2=" | sed "s/^$2=//"
+       echo "$1" | grep -a "^$2=" | sed "s/^$2=//"
 }
 
 # Get the value from a string in the form of var = "value" from a file.
I: using fakeroot in build.
I: pbuilder: network access will be disabled during build
I: Current time: vendredi 24 juillet 2015, 04:40:15 (UTC+1400)
I: pbuilder-time-stamp: 1437662415
I: Building the build Environment
I: extracting base tarball [/var/cache/pbuilder/unstable-reproducible-base.tgz]
I: creating local configuration
I: copying local configuration
I: mounting /proc filesystem
I: mounting /run/shm filesystem
I: mounting /dev/pts filesystem
I: Mounting /dev/shm
I: Mounting /sys
I: policy-rc.d already exists
I: Installing the build-deps
I: user script 
/var/cache/pbuilder/build//33982/tmp/hooks/D01_modify_environment starting
I: Changing hostname to test build reproducibility
I: user script 
/var/cache/pbuilder/build//33982/tmp/hooks/D01_modify_environment finished
 -> Attempting to satisfy build-dependencies
 -> Creating pbuilder-satisfydepends-dummy package
Package: pbuilder-satisfydepends-dummy
Version: 0.invalid.0
Architecture: amd64
Maintainer: Debian Pbuilder Team <pbuilder-ma...@lists.alioth.debian.org>
Description: Dummy package to satisfy dependencies with aptitude - created by 
pbuilder
 This package was created automatically by pbuilder to satisfy the
 build-dependencies of the package being currently built.
Depends: debhelper (>= 9), devio
dpkg-deb: building package 'pbuilder-satisfydepends-dummy' in 
'/tmp/satisfydepends-aptitude/pbuilder-satisfydepends-dummy.deb'.
Selecting previously unselected package pbuilder-satisfydepends-dummy.
(Reading database ... 20236 files and directories currently installed.)
Preparing to unpack .../pbuilder-satisfydepends-dummy.deb ...
Unpacking pbuilder-satisfydepends-dummy (0.invalid.0) ...
dpkg: pbuilder-satisfydepends-dummy: dependency problems, but configuring 
anyway as you requested:
 pbuilder-satisfydepends-dummy depends on devio; however:
  Package devio is not installed.

Setting up pbuilder-satisfydepends-dummy (0.invalid.0) ...
Reading package lists...
Building dependency tree...
Reading state information...
Initializing package states...
Writing extended state information...
Building tag database...
The following NEW packages will be installed:
  devio{a} 
0 packages upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
Need to get 18.0 kB of archives. After unpacking 57.3 kB will be used.
Writing extended state information...
Get: 1 http://ftp.de.debian.org/debian/ unstable/main devio amd64 1.2-1+b1 
[18.0 kB]
Fetched 18.0 kB in 0s (0 B/s)
debconf: delaying package configuration, since apt-utils is not installed
Selecting previously unselected package devio.
(Reading database ... 
(Reading database ... 5%
(Reading database ... 10%
(Reading database ... 15%
(Reading database ... 20%
(Reading database ... 25%
(Reading database ... 30%
(Reading database ... 35%
(Reading database ... 40%
(Reading database ... 45%
(Reading database ... 50%
(Reading database ... 55%
(Reading database ... 60%
(Reading database ... 65%
(Reading database ... 70%
(Reading database ... 75%
(Reading database ... 80%
(Reading database ... 85%
(Reading database ... 90%
(Reading database ... 95%
(Reading database ... 100%
(Reading database ... 20236 files and directories currently installed.)
Preparing to unpack .../devio_1.2-1+b1_amd64.deb ...
Unpacking devio (1.2-1+b1) ...
Processing triggers for man-db (2.7.0.2-5) ...
Setting up devio (1.2-1+b1) ...
Reading package lists...
Building dependency tree...
Reading state information...
Reading extended state information...
Initializing package states...
Writing extended state information...
Building tag database...
 -> Finished parsing the build-deps
Reading package lists...
Building dependency tree...
Reading state information...
fakeroot is already the newest version.
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
I: Copying source file
I: copying [oldsys-preseed_3.18.dsc]
I: copying [./oldsys-preseed_3.18.tar.xz]
I: Extracting source
gpgv: keyblock resource `/tmp/buildd/.gnupg/trustedkeys.gpg': file open error
gpgv: Signature made jeu 23 jui 2015 21:21:59 GMT-14 using RSA key ID 4D6E25A8
gpgv: Can't check signature: public key not found
dpkg-source: warning: failed to verify signature on ./oldsys-preseed_3.18.dsc
dpkg-source: info: extracting oldsys-preseed in oldsys-preseed-3.18
dpkg-source: info: unpacking oldsys-preseed_3.18.tar.xz
I: Building the package
W: no hooks of type A found -- ignoring
I: Running cd tmp/buildd/*/ && env 
PATH="/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/i/capture/the/path" 
dpkg-buildpackage -us -uc  -b -rfakeroot
dpkg-buildpackage: source package oldsys-preseed
dpkg-buildpackage: source version 3.18
dpkg-buildpackage: source distribution unstable
dpkg-buildpackage: source changed by Christian Perrier <bubu...@debian.org>
 dpkg-source --before-build oldsys-preseed-3.18
dpkg-buildpackage: host architecture amd64
 fakeroot debian/rules clean
dh clean
   dh_testdir
   dh_auto_clean
   dh_clean
 debian/rules build
dh build
   dh_testdir
   dh_auto_configure
   dh_auto_build
   debian/rules override_dh_auto_test
make[1]: Entering directory '/tmp/buildd/oldsys-preseed-3.18'
cd tests && ./runtests
Running test arm/dns323-dhcp... ok
Running test arm/dns323-static... ok
Running test arm/kuroboxpro_dhcp... ok
Running test arm/kuroboxpro_static... ok
Running test arm/lspro_dhcp... ok
Running test arm/lspro_static... ok
Running test arm/mv2120_dhcp... ok
Running test arm/mv2120_static... ok
Running test arm/nslu2_invalid_hostname... ok
Running test arm/nslu2_static_no_dns... --- arm/nslu2_static_no_dns.preseed     
2011-05-05 10:29:52.000000000 +1400
+++ /tmp/fileSlf9om     2015-07-24 04:40:44.883126572 +1400
@@ -3,7 +3,7 @@
 d-i netcfg/get_ipaddress string 192.168.1.77
 d-i netcfg/get_netmask string 255.255.255.0
 d-i netcfg/get_gateway string 192.168.1.1
-d-i netcfg/get_nameservers string 192.168.1.1
+d-i netcfg/get_nameservers string Binary file (standard input) matches Binary 
file (standard input) matches Binary file (standard input) matches
 d-i netcfg/choose_interface select eth0
 d-i netcfg/use_dhcp boolean true
-d-i netcfg/get_hostname string foobar
+d-i netcfg/get_domain string Binary file (standard input) matches
not ok
Running test arm/nslu2_static_no_gw... ok
Running test arm/nslu2_static_no_ip... --- arm/nslu2_static_no_ip.preseed       
2011-05-05 10:29:52.000000000 +1400
+++ /tmp/fileAZzknD     2015-07-24 04:40:45.407118543 +1400
@@ -3,7 +3,7 @@
 d-i netcfg/get_ipaddress string 192.168.1.77
 d-i netcfg/get_netmask string 255.255.255.0
 d-i netcfg/get_gateway string 192.168.1.1
-d-i netcfg/get_nameservers string 213.33.99.70
+d-i netcfg/get_nameservers string Binary file (standard input) matches Binary 
file (standard input) matches Binary file (standard input) matches
 d-i netcfg/choose_interface select eth0
 d-i netcfg/use_dhcp boolean true
-d-i netcfg/get_hostname string foobar
+d-i netcfg/get_domain string Binary file (standard input) matches
not ok
Running test arm/nslu2_static... ok
Running test arm/nslu2... ok
Running test arm/nslu2_uninitialized... ok
Running test arm/qnap_dhcp... ok
Running test arm/qnap_static... ok
Running test arm/qnap_static_unreachable_gateway... ok
Running test arm/thecus_dhcp... ok
Running test arm/thecus_static_not_default... ok
Running test misc/gateway... ok
Running test misc/hostname... ok
debian/rules:11: recipe for target 'override_dh_auto_test' failed
make[1]: *** [override_dh_auto_test] Error 1
make[1]: Leaving directory '/tmp/buildd/oldsys-preseed-3.18'
debian/rules:3: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
E: Failed autobuilding of package
W: no hooks of type C found -- ignoring
I: unmounting /sys filesystem
I: unmounting /dev/shm filesystem
I: unmounting dev/pts filesystem
I: unmounting run/shm filesystem
I: unmounting proc filesystem
I: cleaning the build env 
I: removing directory /var/cache/pbuilder/build//33982 and its subdirectories

Reply via email to