Source: pyside-tools Version: 0.2.15-1 Severity: wishlist Tags: patch User: reproducible-bui...@lists.alioth.debian.org Usertags: toolchain timestamps X-Debbugs-Cc: reproducible-bui...@lists.alioth.debian.org
Hi! While working on the "reproducible builds" effort [1], we have noticed that rcc embeds a timestamp into a comment in generated Python code. The attached patch removes the timestamp, since it provides no meaningful information and generates unreproducible files. Regards, Reiner [1]: https://wiki.debian.org/ReproducibleBuilds
diff --git a/debian/patches/reproducible-builds.patch b/debian/patches/reproducible-builds.patch new file mode 100644 index 0000000..67e51a1 --- /dev/null +++ b/debian/patches/reproducible-builds.patch @@ -0,0 +1,22 @@ +Index: pyside-tools-0.2.15/pyrcc/rcc.cpp +=================================================================== +--- pyside-tools-0.2.15.orig/pyrcc/rcc.cpp ++++ pyside-tools-0.2.15/pyrcc/rcc.cpp +@@ -28,7 +28,6 @@ + #include <qfile.h> + #include <qfileinfo.h> + #include <qlocale.h> +-#include <qdatetime.h> + #include <qtextstream.h> + #include <qbytearray.h> + #include <qhash.h> +@@ -398,8 +397,7 @@ RCCResourceLibrary::writeHeader(FILE *ou + fprintf(out, "# -*- coding: utf-8 -*-\n\n"); + fprintf(out, "# Resource object code\n"); + fprintf(out, "#\n"); +- fprintf(out, "# Created: %s\n", QDateTime::currentDateTime().toString().toUtf8().constData()); +- fprintf(out, "# by: The Resource Compiler for PySide (Qt v%s)\n", QT_VERSION_STR); ++ fprintf(out, "# Created by: The Resource Compiler for PySide (Qt v%s)\n", QT_VERSION_STR); + fprintf(out, "#\n"); + fprintf(out, "# WARNING! All changes made in this file will be lost!\n"); + fprintf(out, "\n"); diff --git a/debian/patches/series b/debian/patches/series index 7dd68cf..c1121a5 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -1 +1,2 @@ u_4125d2d_Fix_pysideuictest.patch +reproducible-builds.patch
signature.asc
Description: PGP signature
