Bug#809318: bts: overrides user-specified value of sendmail

2016-03-11 Thread Osamu Aoki
HI, On Thu, Mar 10, 2016 at 11:06:52PM +, Daniel Shahaf wrote: > The noun phrase "configuration file" needs an article: it should say > "Please fix your configuration file" or "Please fix the configuration > file". Good catch! Typical Japanese errors :-) Thanks. I fixed them with "the"

Bug#809318: bts: overrides user-specified value of sendmail

2016-03-10 Thread Daniel Shahaf
Osamu Aoki wrote on Thu, Mar 10, 2016 at 11:52:32 +: > Then its fix should be "die" instead of stop doing sanity check. > > What do you think of attached patch. +1. Your patch would resolve the issue and seems to be the least intrusive way to do so. One comment, below: > - warn

Bug#809318: bts: overrides user-specified value of sendmail

2016-03-10 Thread Osamu Aoki
Package: devscripts Followup-For: Bug #809318 As I understand, the normal bug is about "DEFAULTING TO DEFAULT sendmail". Then its fix should be "die" instead of stop doing sanity check. What do you think of attached patch. Osamu >From ee5b19c7fc488cc503c7ede427492f40e3c5c3da Mon Sep 17

Bug#809318: bts: overrides user-specified value of sendmail

2016-03-09 Thread Daniel Shahaf
Osamu Aoki wrote on Wed, Mar 09, 2016 at 23:39:14 +0900: > control: severity -1 normal > > Hi, > > On Wed, Mar 09, 2016 at 02:22:04PM +, Daniel Shahaf wrote: > > Osamu Aoki wrote on Tue, Mar 08, 2016 at 23:08:58 +0900: > ... > > There are two different issues being discussed in this thread.

Bug#809318: bts: overrides user-specified value of sendmail

2016-03-09 Thread Osamu Aoki
control: severity -1 normal Hi, On Wed, Mar 09, 2016 at 02:22:04PM +, Daniel Shahaf wrote: > Osamu Aoki wrote on Tue, Mar 08, 2016 at 23:08:58 +0900: ... > There are two different issues being discussed in this thread. One of > them is a wishlist item and one of them is not. OK > The

Bug#809318: bts: overrides user-specified value of sendmail

2016-03-09 Thread Daniel Shahaf
Osamu Aoki wrote on Tue, Mar 08, 2016 at 23:08:58 +0900: > I generally do not like to allow "multi words shell commandline" accepted > via command line argument into perl code for security concern. I do > understand the point that "bts" may be safe for such concern. But why > add such capability

Bug#809318: bts: overrides user-specified value of sendmail

2016-03-08 Thread Osamu Aoki
control: severity 809318 wishlist thanks Hi, I generally do not like to allow "multi words shell commandline" accepted via command line argument into perl code for security concern. I do understand the point that "bts" may be safe for such concern. But why add such capability when -n option

Bug#809318: bts: overrides user-specified value of sendmail

2015-12-30 Thread Daniel Shahaf
James McCoy wrote on Tue, Dec 29, 2015 at 08:39:31 -0500: > On Tue, Dec 29, 2015 at 10:15:15AM +, Daniel Shahaf wrote: > > bts(1) sent an email without my permission: > > .. > > % bts --sendmail='() { cat $1 > /dev/tty }' reopen 99 > > --sendmail command contained funny

Bug#809318: bts: overrides user-specified value of sendmail

2015-12-29 Thread James McCoy
On Tue, Dec 29, 2015 at 10:15:15AM +, Daniel Shahaf wrote: > bts(1) sent an email without my permission: > .. > % bts --sendmail='() { cat $1 > /dev/tty }' reopen 99 > --sendmail command contained funny characters: () > Reverting to default value /usr/sbin/sendmail > % >

Bug#809318: bts: overrides user-specified value of sendmail

2015-12-29 Thread Daniel Shahaf
Package: devscripts Version: 2.15.9 Severity: important Dear Maintainer, bts(1) sent an email without my permission: .. % bts --sendmail='() { cat $1 > /dev/tty }' reopen 99 --sendmail command contained funny characters: () Reverting to default value /usr/sbin/sendmail % ..