tags 811767 -help
tags 811767 +patch
thanks

Hi Patrick,

what broke the build of geoip is that gcc 6 changed the default 
C++ standard from C++98 to C++14.

Note that this just changed the default, when told to process C++98 code 
gcc 6 does not differ in any significant way from gcc 5.

Not all valid C++98 code is also valid C++11 and C++14 code.

Making the code compatible with C++14 would be the best possible
solution, but there is nothing wrong with fixing the build with
the following change to tell gcc that this is C++98 code:

--- debian/rules.old    2016-08-19 17:30:30.000000000 +0000
+++ debian/rules        2016-08-19 17:33:09.000000000 +0000
@@ -11,9 +11,9 @@
 override_dh_auto_install:
        $(MAKE) install DESTDIR=$(CURDIR)/debian/tmp
        # Build the build script.
-       $(CXX) $(CPPFLAGS) $(LDFLAGS) -g debian/src/geoip-csv-to-dat.cpp -o 
debian/tmp/geoip-generator -lGeoIP \
+       $(CXX) $(CPPFLAGS) -std=gnu++98 $(LDFLAGS) -g 
debian/src/geoip-csv-to-dat.cpp -o debian/tmp/geoip-generator -lGeoIP \
                -I $(CURDIR)/debian/tmp/usr/include/ -L 
$(CURDIR)/debian/tmp/usr/lib/$(DEB_HOST_MULTIARCH)/
-       $(CXX) $(CPPFLAGS) $(LDFLAGS) -g debian/src/geoip-asn-csv-to-dat.cpp -o 
debian/tmp/geoip-generator-asn -lGeoIP \
+       $(CXX) $(CPPFLAGS) -std=gnu++98 $(LDFLAGS) -g 
debian/src/geoip-asn-csv-to-dat.cpp -o debian/tmp/geoip-generator-asn -lGeoIP \
                -I $(CURDIR)/debian/tmp/usr/include/ -L 
$(CURDIR)/debian/tmp/usr/lib/$(DEB_HOST_MULTIARCH)/
        chrpath -d -k debian/tmp/usr/bin/geoip*
 

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Reply via email to