Control: tags 812165 + patch

While checking rdeps of xapian-core in preparation for the upcoming
transition to xapian-core 1.4.0, I hit the current FTBFS of pinot with
GCC6.  The attached patch fixes that FTBFS.

However, the resulting build segfaults when the pinot binary is run.
A brief investigation suggests it's some sort of symbol mangling issue
as this log entry appears:

$ more ~/.pinot/pinot.log
FilterFactory::loadFilters: /usr/lib/pinot/filters/libexternalfilter.so: 
undefined symbol: _Z16get_filter_typesRSt3setISsSt4lessISsESaISsEE

I'm not an active user of pinot, so didn't have a .pinot before trying
to fix this FTBFS.

Incidentally, I notice there's also a newer release of pinot: 1.08.  The
current watch file isn't showing this, I suspect due to google code
going read-only.

Cheers,
    Olly
diff -Nru pinot-1.05/debian/changelog pinot-1.05/debian/changelog
--- pinot-1.05/debian/changelog	2015-09-07 17:59:39.000000000 +1200
+++ pinot-1.05/debian/changelog	2016-08-06 12:13:24.000000000 +1200
@@ -1,3 +1,11 @@
+pinot (1.05-1.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix to build with GCC6, new patch: fix-ftbfs-with-gcc6.patch
+    (Closes: #812165)
+
+ -- Olly Betts <o...@survex.com>  Sat, 06 Aug 2016 12:12:06 +1200
+
 pinot (1.05-1.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru pinot-1.05/debian/patches/fix-ftbfs-with-gcc6.patch pinot-1.05/debian/patches/fix-ftbfs-with-gcc6.patch
--- pinot-1.05/debian/patches/fix-ftbfs-with-gcc6.patch	1970-01-01 12:00:00.000000000 +1200
+++ pinot-1.05/debian/patches/fix-ftbfs-with-gcc6.patch	2016-08-06 12:02:50.000000000 +1200
@@ -0,0 +1,17 @@
+Description: Fix to build with GCC6
+Author: Olly Betts <o...@survex.com>
+Bug-Debian: https://bugs.debian.org/812165
+Forwarded: no
+Last-Update: 2016-08-06
+
+--- pinot-1.05.orig/IndexSearch/ModuleFactory.cpp
++++ pinot-1.05/IndexSearch/ModuleFactory.cpp
+@@ -132,7 +132,7 @@ IndexInterface *ModuleFactory::getLibrar
+ 		(typeIter->second.m_canIndex == false))
+ 	{
+ 		// We don't know about this type, or doesn't support indexes
+-		return false;
++		return NULL;
+ 	}
+ 
+ 	void *pHandle = typeIter->second.m_pHandle;
diff -Nru pinot-1.05/debian/patches/series pinot-1.05/debian/patches/series
--- pinot-1.05/debian/patches/series	2012-06-23 15:36:32.000000000 +1200
+++ pinot-1.05/debian/patches/series	2016-08-06 12:02:22.000000000 +1200
@@ -1 +1,2 @@
 boost1.48.patch
+fix-ftbfs-with-gcc6.patch

Attachment: signature.asc
Description: PGP signature

Reply via email to