Bug#813609: cron-apt: XHEADER config option messes up mail headers

2016-06-14 Thread Ola Lundqvist
Hi I realize now that I only sent to the bug id and not to you? Thanks! Yes I missed that. Thanks. I'll give credits to you in the debian changelog. Is it ok if I write the email address there? // Ola On Tue, May 17, 2016 at 2:59 PM, Ola Lundqvist wrote: > Thanks! Yes I

Bug#813609: cron-apt: XHEADER config option messes up mail headers

2016-05-17 Thread Ola Lundqvist
Thanks! Yes I missed that. Thanks. I'll give credits to you in the debian changelog. Is it ok if I write the email address there? / Ola Sent from a phone Den 17 maj 2016 14:24 skrev "Geoff" : > Hi, > > The temporary IFS overriding is necessary IMHO, otherwise the test on

Bug#813609: cron-apt: XHEADER config option messes up mail headers

2016-05-17 Thread Geoff
Hi, The temporary IFS overriding is necessary IMHO, otherwise the test on $VAL non-emptiness might failed/raised an error for header with space, for instance with header like: "X-My-Header: string". To remove IFS overriding completely, we need to quote $VAL i think:

Bug#813609: cron-apt: XHEADER config option messes up mail headers

2016-05-17 Thread Ola Lundqvist
Hi again I have done some more changes. Can you test with this file? // Ola On Tue, May 17, 2016 at 10:59 AM, Geoff wrote: > Hi, > > Le 03/05/2016 23:51, Ola Lundqvist a écrit : > >> Hi again >> >> No sorry, replace the with nothing or space. That should do the >> trick.

Bug#813609: cron-apt: XHEADER config option messes up mail headers

2016-05-17 Thread Ola Lundqvist
Hi Geoff Thanks a lot! Yes this should solve the problem. I'll apply it soon. // Ola On Tue, May 17, 2016 at 10:59 AM, Geoff wrote: > Hi, > > Le 03/05/2016 23:51, Ola Lundqvist a écrit : > >> Hi again >> >> No sorry, replace the with nothing or space. That should do the

Bug#813609: cron-apt: XHEADER config option messes up mail headers

2016-05-17 Thread Geoff
Hi, Le 03/05/2016 23:51, Ola Lundqvist a écrit : Hi again No sorry, replace the with nothing or space. That should do the trick. Replacing "" with nothing is not enough. Each XHEADER has to be quoted as well. Mail command with cli options is then eval. Here is a quick and not so pretty

Bug#813609: cron-apt: XHEADER config option messes up mail headers

2016-05-03 Thread Ola Lundqvist
Hi again No sorry, replace the with nothing or space. That should do the trick. // Ola On Tue, May 3, 2016 at 11:45 PM, Ola Lundqvist wrote: > Hi > > Sorry for a long delay with the reply. I just saw this but report among a > long list of auto-filed bug reports. > > I have

Bug#813609: cron-apt: XHEADER config option messes up mail headers

2016-05-03 Thread Ola Lundqvist
Hi Sorry for a long delay with the reply. I just saw this but report among a long list of auto-filed bug reports. I have no memory of adding this support myself and when looking through the code and your result I fully understand why it becomes like this. The code should most probably not have a

Bug#813609: cron-apt: XHEADER config option messes up mail headers

2016-02-03 Thread Geoff
Package: cron-apt Version: 0.9.2 Severity: normal Dear Maintainer, * What led up to the situation? Add the header option in the config file: XHEADER1="X-MYHDR-security: cron-apt" * What was the outcome of this action? The mail header "To" ended up wrong: To: