Bug#824900: RFS: iroffer-dinoex/3.30-1 [ITP]

2016-06-02 Thread optix2000
Hi Mentors, I've pushed a new build onto mentors.debian.net that should resolve most of the aforementioned issues. Can someone give it another look? Thanks! Weilu

Bug#824900: RFS: iroffer-dinoex/3.30-1 [ITP]

2016-05-21 Thread optix2000
> > > d/rules: > > > - why -D_FORTIFY_SOURCE=1? Such things should be documented > > > > For security reasons, as this is an internet accessible daemon that > > accepts user input. > What I've meant was "you replaced stronger default flag with a weaker > one". As you know about dpkg-buildflags

Bug#824900: RFS: iroffer-dinoex/3.30-1 [ITP]

2016-05-21 Thread Andrey Rahmatullin
On Sat, May 21, 2016 at 02:02:49PM -0700, optix2...@teitoku.net wrote: > > d/rules: > > - why -D_FORTIFY_SOURCE=1? Such things should be documented > > For security reasons, as this is an internet accessible daemon that > accepts user input. What I've meant was "you replaced stronger default

Bug#824900: RFS: iroffer-dinoex/3.30-1 [ITP]

2016-05-21 Thread optix2000
>> iroffer-dinoex.lintian-overrides: >> - you shouldn't override P tags >Which P tag did I override? no-upstream-changelog should be an I tag. Sorry, I looked again and you're right. no-upstream-changelog is a P tag. I've removed the override. Regards, Weilu

Bug#824900: RFS: iroffer-dinoex/3.30-1 [ITP]

2016-05-21 Thread optix2000
Hi Andrey, Thanks for looking over this. I've replied to your concerns in line and created a new build which (hopefully) addresses most of them. > d/rules: > - why -D_FORTIFY_SOURCE=1? Such things should be documented For security reasons, as this is an internet accessible daemon that accepts

Bug#824900: RFS: iroffer-dinoex/3.30-1 [ITP]

2016-05-21 Thread Andrey Rahmatullin
(Note that I don't intend to sponsor this package) d/rules: - why -D_FORTIFY_SOURCE=1? Such things should be documented - commented out -Wl,--as-needed looks strange, if it doesn't work/isn't needed you shouldn't include this line at all - you can probably replace override_dh_auto_clean with

Bug#824900: RFS: iroffer-dinoex/3.30-1 [ITP]

2016-05-20 Thread optix2000
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "iroffer-dinoex" Package name: iroffer-dinoex Version : 3.30-1 Upstream Author : Dirk Meyer URL : http://iroffer.dinoex.net License : GPL-2 Section