Bug#830979: Bug#831984: zoneminder: modifies shipped file: /usr/share/zoneminder/www/api/app/Config/core.php

2016-07-31 Thread Dmitry Smirnov
On Thursday, 21 July 2016 10:05:41 AM AEST Chris Lamb wrote: > > Something like the attached patch? (Untested) > > Had more time than I thought; updated and (quickly) tested patch > attached. Chris, thank you very much for all your help. I've incorporated your patch and it will be uploaded soon.

Bug#830979: Bug#831984: zoneminder: modifies shipped file: /usr/share/zoneminder/www/api/app/Config/core.php

2016-07-21 Thread Dmitry Smirnov
On Thursday, 21 July 2016 9:31:47 AM AEST Chris Lamb wrote: > This seems an odd.attitude to have as the maintainer.. :) Sorry if I didn't make it clear: I'm not blaming anyone, it was a oversight on my side which will be fixed. Chris, since I applied your patch I wanted you to get a feedback of

Bug#830979: Bug#831984: zoneminder: modifies shipped file: /usr/share/zoneminder/www/api/app/Config/core.php

2016-07-21 Thread Chris Lamb
> postrm purge should delete /etc/zm/core.php, shouldn't it? Probably. Patches are proof of concept, am not the maintainer/user here. :) > What should happen if core.php.default changes its content? There are a > lot of options, maybe a new one is added some day ... Good point. So maybe the mai

Bug#830979: Bug#831984: zoneminder: modifies shipped file: /usr/share/zoneminder/www/api/app/Config/core.php

2016-07-21 Thread Andreas Beckmann
On 2016-07-21 10:05, Chris Lamb wrote: >> Something like the attached patch? (Untested) > > Had more time than I thought; updated and (quickly) tested patch > attached. postrm purge should delete /etc/zm/core.php, shouldn't it? What should happen if core.php.default changes its content? There ar

Bug#830979: Bug#831984: zoneminder: modifies shipped file: /usr/share/zoneminder/www/api/app/Config/core.php

2016-07-21 Thread Chris Lamb
> Something like the attached patch? (Untested) Had more time than I thought; updated and (quickly) tested patch attached. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- diff --git a/debian/rules b/debian/rules index f4a187f..

Bug#830979: Bug#831984: zoneminder: modifies shipped file: /usr/share/zoneminder/www/api/app/Config/core.php

2016-07-21 Thread Chris Lamb
> Well, you don't edit shipped files. Neither conffiles nor normal files. > Instead, you put these values into a new file (not a shipped file!, > maybe ship a template in /usr/share/$pkg) in either /etc or /var (with a > symlink in /usr pointing to it) that is solely managed by the maintainer > scr

Bug#830979: Bug#831984: zoneminder: modifies shipped file: /usr/share/zoneminder/www/api/app/Config/core.php

2016-07-20 Thread Andreas Beckmann
On 2016-07-21 02:57, Dmitry Smirnov wrote: > I guess you guys can have an interesting discussion about clash between > #830979 and #831984. ;) Well, you don't edit shipped files. Neither conffiles nor normal files. Instead, you put these values into a new file (not a shipped file!, maybe ship a t

Bug#830979: Bug#831984: zoneminder: modifies shipped file: /usr/share/zoneminder/www/api/app/Config/core.php

2016-07-20 Thread Dmitry Smirnov
On Thursday, 21 July 2016 1:08:10 AM AEST Andreas Beckmann wrote: > Package: zoneminder > Version: 1.30.0~rc2+dfsg-1 > Severity: serious > User: debian...@lists.debian.org > Usertags: piuparts > > Hi, > > during a test with piuparts I noticed your package modifies a shipped > file: > > 1m41.6s E