I've found a couple of other nits that could be fixed, see attached patch. There was one item I was unsure about so I left it out of the patch. The manual page says the default is
reassign_maps = yes but libmultipath/defaults.h says #define DEFAULT_REASSIGN_MAPS 0 This gets used like so multipath/config.c: conf->reassign_maps = DEFAULT_REASSIGN_MAPS; and in multipath/main.c: } else if (conf->reassign_maps) { condlog(3, "%s: Reassign existing device-mapper" " devices", ompp->alias); dm_reassign(ompp->alias); } so it looks like the code default is 'no'. Vince
Tweaks to the manual page Fixed default for prio, taken from libmultipath/prio.h: #define DEFAULT_PRIO "const" Additions, taken from libmultipath/defaults.h path_selector #define DEFAULT_SELECTOR "service-time 0" fast_io_fail_tmo #define DEFAULT_FAST_IO_FAIL 5 Added a pointer to the precedence rules related to queue_if_no_path. diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5 index 2ff88c4..87d5621 100644 --- a/multipath/multipath.conf.5 +++ b/multipath/multipath.conf.5 @@ -139,6 +139,8 @@ Send the next bunch of IO down the path with the least amount of outstanding IO. .B "service-time 0" Choose the path for the next bunch of IO based on the amount of outstanding IO to the path and its relative throughput. +.TP +Default value is \fBservice-time 0\fR. .RE .TP .B path_grouping_policy @@ -217,7 +219,7 @@ Generate a random priority between 1 and 10. Generate the path priority based on the regular expression and the priority provided as argument. requires prio_args keyword. .TP -Default value is \fBnone\fR. +Default value is \fBconst\fR. .RE .TP .B prio_args @@ -256,9 +258,12 @@ Possible values for the feature list are .RS .TP 12 .B queue_if_no_path -Queue IO if no path is active; identical to the +Queue IO if no path is active; identical to setting the .I no_path_retry -keyword. +keyword to +.I queue. +See also \fBKNOWN ISSUES\fR. +. .TP .B no_partitions Disable automatic partitions generation via kpartx. @@ -382,7 +387,7 @@ Specify the number of seconds the scsi layer will wait after a problem has been detected on a FC remote port before failing IO to devices on that remote port. This should be smaller than dev_loss_tmo. Setting this to .I off -will disable the timeout. +will disable the timeout. Default is 5. .TP .B dev_loss_tmo Specify the number of seconds the scsi layer will wait after a problem has