Bug#849957: llmnrd: tidy up and improve init script

2017-01-07 Thread Andreas Henriksson
On Sat, Jan 07, 2017 at 09:16:58PM +0100, Pali Rohár wrote: > That sounds strange as calling init script is standard way how to start > or stop some service in Linux and Unix world for a very long time... No, calling init scripts directly brings only pain given that you'll leak your environment i

Bug#849957: llmnrd: tidy up and improve init script

2017-01-07 Thread Pali Rohár
On Saturday 07 January 2017 19:19:06 Andreas Henriksson wrote: > On Sat, Jan 07, 2017 at 01:47:17PM +0100, Pali Rohár wrote: > [...] > > > [ ok ] Stopping llmnrd (via systemctl): llmnrd.service. > > > > You should fill same bug to systemd to fix their 40-systemd script. > > I agree with you tha

Bug#849957: llmnrd: tidy up and improve init script

2017-01-07 Thread Andreas Henriksson
On Sat, Jan 07, 2017 at 01:47:17PM +0100, Pali Rohár wrote: [...] > [ ok ] Stopping llmnrd (via systemctl): llmnrd.service. > > You should fill same bug to systemd to fix their 40-systemd script. I > agree with you that non-systemd message is better, but systemd needs to > be fixed first. Thi

Bug#849957: llmnrd: tidy up and improve init script

2017-01-07 Thread Pali Rohár
On Monday 02 January 2017 17:40:22 you wrote: > - setting DESC to a (short) description. Setting it to the same as > NAME just means the output will contain the same thing twice. Same thing is doing systemd and Debian's transition script: /lib/lsb/init-functions.d/40-systemd systemctl_redirect

Bug#849957: llmnrd: tidy up and improve init script

2017-01-07 Thread Pali Rohár
Hi! On Monday 02 January 2017 17:40:22 you wrote: > - possibly also consider implementing the 'try-reload' action > as described by LSB. (Eg. restart, but only if already running.) LSB [1] does not specify any 'try-reload' action. There is only 'try-restart' which is only optional. But other c

Bug#849957: llmnrd: tidy up and improve init script

2017-01-02 Thread Andreas Henriksson
Package: llmnrd Version: 0.2.1-1 Severity: wishlist Dear Maintainer, Please consider cleaning out all the unused boilerplate from the init script. Just remove the commented out stuff you don't intend to use. While doing so please also consider other improvements like: - setting DESC to a (short