Bug#857089: Fix dh_installinit options

2017-03-17 Thread Wolfgang Schweer
Hi Evgeni, On Sun, Mar 12, 2017 at 06:37:56PM +0100, Evgeni Golov wrote: > On Sun, Mar 12, 2017 at 06:30:52PM +0100, Wolfgang Schweer wrote: > > On Sun, Mar 12, 2017 at 06:04:00PM +0100, Evgeni Golov wrote: > > > On Sun, Mar 12, 2017 at 05:42:34PM +0100, Wolfgang Schweer wrote: > > > > One point:

Bug#857089: Fix dh_installinit options

2017-03-12 Thread Evgeni Golov
On Sun, Mar 12, 2017 at 06:30:52PM +0100, Wolfgang Schweer wrote: > On Sun, Mar 12, 2017 at 06:04:00PM +0100, Evgeni Golov wrote: > > On Sun, Mar 12, 2017 at 05:42:34PM +0100, Wolfgang Schweer wrote: > > > One point: > > > For the d/NEWS file to be actually shipped, at least for me this > > >

Bug#857089: Fix dh_installinit options

2017-03-12 Thread Wolfgang Schweer
On Sun, Mar 12, 2017 at 06:04:00PM +0100, Evgeni Golov wrote: > On Sun, Mar 12, 2017 at 05:42:34PM +0100, Wolfgang Schweer wrote: > > One point: > > For the d/NEWS file to be actually shipped, at least for me this > > additional patch was needed: > > Uh? It should be automatically installed by

Bug#857089: Fix dh_installinit options

2017-03-12 Thread Evgeni Golov
Hey, On Sun, Mar 12, 2017 at 05:42:34PM +0100, Wolfgang Schweer wrote: > On Sun, Mar 12, 2017 at 09:16:46AM +0100, Evgeni Golov wrote: > > I went a bit further, droped that code, and migrated the setting > > to update-rc.d on upgrade. See attached patchset. > > > > What do you think? > > Looks

Bug#857089: Fix dh_installinit options

2017-03-12 Thread Wolfgang Schweer
On Sun, Mar 12, 2017 at 09:16:46AM +0100, Evgeni Golov wrote: > I went a bit further, droped that code, and migrated the setting > to update-rc.d on upgrade. See attached patchset. > > What do you think? Looks awesome. Tested all possible variants using both systemd and sysv related commands.

Bug#857089: Fix dh_installinit options

2017-03-12 Thread Evgeni Golov
Hi, On Sat, Mar 11, 2017 at 10:03:34PM +0100, Wolfgang Schweer wrote: > > There is still one thing left: in the SysV case, the user will have to > > issue update-rc.d thinkfan enable AND edit /etc/default/thinkfan. > > > > Thinking how to fix that. > > I guess it would be sufficient to add a

Bug#857089: Fix dh_installinit options

2017-03-11 Thread Wolfgang Schweer
On Sat, Mar 11, 2017 at 09:41:55PM +0100, Evgeni Golov wrote: > On Sat, Mar 11, 2017 at 08:58:23PM +0100, Wolfgang Schweer wrote: > > On Sat, Mar 11, 2017 at 03:12:48PM +0100, Evgeni Golov wrote: > > > But with the help of fsateler and the postinst of src:puppet, I think I > > > now > > > have a

Bug#857089: Fix dh_installinit options

2017-03-11 Thread Evgeni Golov
Hi, On Sat, Mar 11, 2017 at 08:58:23PM +0100, Wolfgang Schweer wrote: > On Sat, Mar 11, 2017 at 03:12:48PM +0100, Evgeni Golov wrote: > > But with the help of fsateler and the postinst of src:puppet, I think I now > > have a working solution. Just call update-rc.d disable on a fresh install. > >

Bug#857089: Fix dh_installinit options

2017-03-11 Thread Wolfgang Schweer
On Sat, Mar 11, 2017 at 03:12:48PM +0100, Evgeni Golov wrote: > But with the help of fsateler and the postinst of src:puppet, I think I now > have a working solution. Just call update-rc.d disable on a fresh install. > > Can you please test the attached patch? Tested on an up-to-date stretch

Bug#857089: Fix dh_installinit options

2017-03-11 Thread Evgeni Golov
Hi, On Sat, Mar 11, 2017 at 02:35:20PM +0100, Wolfgang Schweer wrote: > > To recap, the behaviour should be as follows (IMHO): > > on fresh install, the service is disabled and not started > > on upgrade > > * if the service was enabled, it remains enabled and gets restarted > > * if the service

Bug#857089: Fix dh_installinit options

2017-03-11 Thread Wolfgang Schweer
Hi Evgeni, On Sat, Mar 11, 2017 at 02:15:06PM +0100, Evgeni Golov wrote: > To recap, the behaviour should be as follows (IMHO): > on fresh install, the service is disabled and not started > on upgrade > * if the service was enabled, it remains enabled and gets restarted > * if the service was

Bug#857089: Fix dh_installinit options

2017-03-11 Thread Evgeni Golov
Hi Wolfgang, On Sat, Mar 11, 2017 at 01:57:47PM +0100, Wolfgang Schweer wrote: > Hi Evgeni, > > On Sat, Mar 11, 2017 at 12:34:18PM +0100, Evgeni Golov wrote: > > > override_dh_installinit: > > > - dh_installinit --onlyscripts > > > + dh_installinit --only-scripts --no-start > > > > Sadly, it

Bug#857089: Fix dh_installinit options

2017-03-11 Thread Wolfgang Schweer
Hi Evgeni, On Sat, Mar 11, 2017 at 12:34:18PM +0100, Evgeni Golov wrote: > > override_dh_installinit: > > - dh_installinit --onlyscripts > > + dh_installinit --only-scripts --no-start > > Sadly, it is not that easy. --no-start implies that the daemon also won't be > re-started on upgrades.

Bug#857089: Fix dh_installinit options

2017-03-11 Thread Evgeni Golov
Hi Wolfgang, On Wed, Mar 08, 2017 at 11:45:45PM +0100, Wolfgang Schweer wrote: > the attached patch seems to work for me. > Please test. Thanks for the patch! > override_dh_installinit: > - dh_installinit --onlyscripts > + dh_installinit --only-scripts --no-start Sadly, it is not

Bug#857089: Fix dh_installinit options

2017-03-08 Thread Wolfgang Schweer
Hi, the attached patch seems to work for me. Please test. Wolfgang From 4cd12369ca5b1fc384043edf32bd1498cf5bb082 Mon Sep 17 00:00:00 2001 From: Wolfgang Schweer Date: Wed, 8 Mar 2017 23:28:40 +0100 Subject: [PATCH] debian/rules: Fix typo in dh_installinit option, add option