Bug#857803: [Pkg-shadow-devel] Bug#857803: shadow: Make the sp_lstchg shadow field reproducible.

2017-04-10 Thread Chris Lamb
forwarded 857803 https://github.com/shadow-maint/shadow/pull/71 thanks Hi Serge, > Right, sudo does but just setuid-root does not. This env variable > is for reproducible builds, so can we check ruid==0 and ignore the > env variable if not? Or do the build scripts also run as non-root? Great

Bug#857803: [Pkg-shadow-devel] Bug#857803: shadow: Make the sp_lstchg shadow field reproducible.

2017-04-09 Thread Serge E. Hallyn
Quoting Chris Lamb (la...@debian.org): > Hi Serge, > > > > > looks ok to me, although, would it be better to fall back to time(NULL) > > > > if the env variable is invalid? > > > > > > In my experience it is far superior to explicitly error out in this > > > situation. > > > > My concern is

Bug#857803: [Pkg-shadow-devel] Bug#857803: shadow: Make the sp_lstchg shadow field reproducible.

2017-04-09 Thread Chris Lamb
Hi Serge, > > > looks ok to me, although, would it be better to fall back to time(NULL) > > > if the env variable is invalid? > > > > In my experience it is far superior to explicitly error out in this > > situation. > > My concern is unprivileged users causing unexpected failure in a more >

Bug#857803: [Pkg-shadow-devel] Bug#857803: shadow: Make the sp_lstchg shadow field reproducible.

2017-04-09 Thread Serge E. Hallyn
On Sun, Apr 09, 2017 at 10:07:38AM +0100, Chris Lamb wrote: > Serge E. Hallyn wrote: > > > looks ok to me, although, would it be better to fall back to time(NULL) > > if the env variable is invalid? > > In my experience it is far superior to explicitly error out in this > situation. My concern

Bug#857803: [Pkg-shadow-devel] Bug#857803: shadow: Make the sp_lstchg shadow field reproducible.

2017-04-09 Thread Chris Lamb
Serge E. Hallyn wrote: > looks ok to me, although, would it be better to fall back to time(NULL) > if the env variable is invalid? In my experience it is far superior to explicitly error out in this situation. It's much better end-user debugging experience than the build "silently" not being

Bug#857803: [Pkg-shadow-devel] Bug#857803: shadow: Make the sp_lstchg shadow field reproducible.

2017-04-07 Thread Serge E. Hallyn
Quoting Chris Lamb (la...@debian.org): > Package: shadow > Severity: wishlist > Version: 1:4.4-4 > Tags: patch > User: reproducible-bui...@lists.alioth.debian.org > Usertags: toolchain > X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org > > Hi, > > Attached is the following: > > commit