Package: release.debian.org
Severity: normal
User: release.debian....@packages.debian.org
Usertags: unblock
Please unblock package libsecret
This version fixes ##855951 "libsecret FTBFS with test failures on
many architectures". I've included the debdiff between the last
version in testing and this proposed new version.
unblock libsecret/0.18.5-3.1
-- System Information:
Debian Release: 9.0
APT prefers testing
APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 4.9.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
diff -Nru libsecret-0.18.5/debian/changelog libsecret-0.18.5/debian/changelog
--- libsecret-0.18.5/debian/changelog 2016-09-04 12:16:44.000000000 +0200
+++ libsecret-0.18.5/debian/changelog 2017-03-18 16:56:31.000000000 +0100
@@ -1,3 +1,25 @@
+libsecret (0.18.5-3.1) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * debian/patches/0004-tests-collection-add-setup-delay.patch:
+ + Fix failing test "collection/delete-sync" by correctly placing
+ the delay. Closes: #855951.
+
+ -- Carsten Leonhardt <l...@debian.org> Sat, 18 Mar 2017 15:56:31 +0000
+
+libsecret (0.18.5-3) unstable; urgency=medium
+
+ [ Jeremy Bicha ]
+ * Add basic autopkgtest to run upstream build tests
+
+ [ Emilio Pozuelo Monfort ]
+ * debian/patches/0004-tests-collection-add-setup-delay.patch:
+ + Add some delay for the test bus to go up and down. Fixes a test
+ that otherwise may fail, especially when running on a single cpu
+ machine. Closes: #837067.
+
+ -- Emilio Pozuelo Monfort <po...@debian.org> Tue, 21 Feb 2017 22:57:01 +0100
+
libsecret (0.18.5-2) unstable; urgency=medium
* Drop --disable-silent-rules from debian/rules. This is now handled by dh
diff -Nru libsecret-0.18.5/debian/control libsecret-0.18.5/debian/control
--- libsecret-0.18.5/debian/control 2016-09-04 12:16:44.000000000 +0200
+++ libsecret-0.18.5/debian/control 2017-03-18 16:56:31.000000000 +0100
@@ -6,7 +6,7 @@
Section: devel
Priority: optional
Maintainer: Debian GNOME Maintainers <pkg-gnome-maintain...@lists.alioth.debian.org>
-Uploaders: Andreas Henriksson <andr...@fatal.se>, Michael Biebl <bi...@debian.org>, Sjoerd Simons <sjo...@debian.org>
+Uploaders: Andreas Henriksson <andr...@fatal.se>, Emilio Pozuelo Monfort <po...@debian.org>, Michael Biebl <bi...@debian.org>
Build-Depends: debhelper (>= 9),
dh-autoreconf,
intltool (>= 0.35.0),
diff -Nru libsecret-0.18.5/debian/patches/0004-tests-collection-add-setup-delay.patch libsecret-0.18.5/debian/patches/0004-tests-collection-add-setup-delay.patch
--- libsecret-0.18.5/debian/patches/0004-tests-collection-add-setup-delay.patch 1970-01-01 01:00:00.000000000 +0100
+++ libsecret-0.18.5/debian/patches/0004-tests-collection-add-setup-delay.patch 2017-03-18 16:55:44.000000000 +0100
@@ -0,0 +1,27 @@
+Author: Emilio Pozuelo Monfort <po...@debian.org>
+Bug: https://bugzilla.gnome.org/show_bug.cgi?id=779041
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=837067
+
+Update by Carsten Leonhardt <l...@debian.org>: move sleep(1) to the
+beginning of teardown() to address bug #855951
+
+Index: libsecret-0.18.5/libsecret/test-collection.c
+===================================================================
+--- libsecret-0.18.5.orig/libsecret/test-collection.c
++++ libsecret-0.18.5/libsecret/test-collection.c
+@@ -56,12 +56,15 @@ setup (Test *test,
+ test->service = secret_service_get_sync (SECRET_SERVICE_NONE, NULL, &error);
+ g_assert_no_error (error);
+ g_object_add_weak_pointer (G_OBJECT (test->service), (gpointer *)&test->service);
++
++ sleep(1);
+ }
+
+ static void
+ teardown (Test *test,
+ gconstpointer unused)
+ {
++ sleep(1);
+ g_object_unref (test->service);
+ secret_service_disconnect ();
+ g_assert (test->service == NULL);
diff -Nru libsecret-0.18.5/debian/patches/series libsecret-0.18.5/debian/patches/series
--- libsecret-0.18.5/debian/patches/series 2016-09-04 01:19:53.000000000 +0200
+++ libsecret-0.18.5/debian/patches/series 2017-02-21 22:56:07.000000000 +0100
@@ -1,3 +1,4 @@
0001-build-Port-to-Python-3.patch
0002-libsecret-Get-rid-of-PyGI-warnings-about-unspecified.patch
0003-Makefile.am-Compile-vala-unstable-tests-with-SECRET_.patch
+0004-tests-collection-add-setup-delay.patch
diff -Nru libsecret-0.18.5/debian/tests/build libsecret-0.18.5/debian/tests/build
--- libsecret-0.18.5/debian/tests/build 1970-01-01 01:00:00.000000000 +0100
+++ libsecret-0.18.5/debian/tests/build 2016-09-05 22:30:15.000000000 +0200
@@ -0,0 +1,2 @@
+#!/bin/sh
+env -u LD_PRELOAD dbus-run-session -- make check
diff -Nru libsecret-0.18.5/debian/tests/control libsecret-0.18.5/debian/tests/control
--- libsecret-0.18.5/debian/tests/control 1970-01-01 01:00:00.000000000 +0100
+++ libsecret-0.18.5/debian/tests/control 2016-09-05 22:30:15.000000000 +0200
@@ -0,0 +1,3 @@
+Tests: build
+Depends: @, @builddeps@
+Restrictions: build-needed
