Bug#858860: RFS: arpwatch [ITA]

2017-04-09 Thread Lukas Schwaighofer
Hi Hugo, On Wed, 5 Apr 2017 18:25:04 +0200 Hugo Lefeuvre wrote: > Are you already a member of the team ? If yes, could you move your git > repository to > https://anonscm.debian.org/git/pkg-security/arpwatch.git ? I've now officially joined the team, the repository is

Bug#858860: RFS: arpwatch [ITA]

2017-04-07 Thread Gianfranco Costamagna
Hello, The reason for not using a "dirs" file is that in general the upstream build system should work "alone", without external helping from our side. This patch is upstreamable, and fixes the issue for other distros out there. Having such custom hacks in debian packaging hides the problem,

Bug#858860: RFS: arpwatch [ITA]

2017-04-06 Thread Hugo Lefeuvre
> * Does somebody have a recommendation regarding the version for > experimental (add ~exp1 or just increase the version once more when > uploading to unstable after stretch was released)? I think you don't need the ~exp1. For your next upload to unstable, you'll just have to increase the

Bug#858860: RFS: arpwatch [ITA]

2017-04-06 Thread Lukas Schwaighofer
On Thu, 6 Apr 2017 15:24:04 + (UTC) Gianfranco Costamagna wrote: > - $(INSTALL) -m 555 -o bin -g bin arpwatch $(DESTDIR)$(BINDEST) > + $(INSTALL) -Dm 555 -o bin -g bin arpwatch $(DESTDIR)$(BINDEST) > > > this should work too (as said above) and is less

Bug#858860: RFS: arpwatch [ITA]

2017-04-06 Thread Hugo Lefeuvre
> - $(INSTALL) -m 555 -o bin -g bin arpwatch $(DESTDIR)$(BINDEST) > + $(INSTALL) -Dm 555 -o bin -g bin arpwatch $(DESTDIR)$(BINDEST) > > > this should work too (as said above) and is less invasive :) Oh right, thanks :) -- Hugo Lefeuvre (hle)|www.owl.eu.com

Bug#858860: RFS: arpwatch [ITA]

2017-04-06 Thread Gianfranco Costamagna
Hello, - $(INSTALL) -m 555 -o bin -g bin arpwatch $(DESTDIR)$(BINDEST) + $(INSTALL) -Dm 555 -o bin -g bin arpwatch $(DESTDIR)$(BINDEST) this should work too (as said above) and is less invasive :) G.

Bug#858860: RFS: arpwatch [ITA]

2017-04-06 Thread Hugo Lefeuvre
Hi Christian, Lukas, > It does solve the problem (i.e. the error is gone if `usr/sbin` is > present in the `dirs` file). According to the Debian New Maintainers' > Guide guide, creating directories that are not created by > `make install DESTDIR=...` as invoked by dh_auto_install is exactly >

Bug#858860: RFS: arpwatch [ITA]

2017-04-06 Thread Christian Seiler
On 04/06/2017 02:51 PM, Lukas Schwaighofer wrote: > Hi Christian, > > On Thu, 6 Apr 2017 14:30:24 +0200 > Christian Seiler wrote: >> The problem is that dirs is only interpreted by dh_installdirs, which >> is typically run after dh_auto_install, so that wouldn't actually >>

Bug#858860: RFS: arpwatch [ITA]

2017-04-06 Thread Lukas Schwaighofer
Hi Christian, On Thu, 6 Apr 2017 14:30:24 +0200 Christian Seiler wrote: > The problem is that dirs is only interpreted by dh_installdirs, which > is typically run after dh_auto_install, so that wouldn't actually > solve your problem. It does solve the problem (i.e. the error

Bug#858860: RFS: arpwatch [ITA]

2017-04-06 Thread Christian Seiler
On 04/05/2017 07:02 PM, Lukas Schwaighofer wrote: > On Wed, 5 Apr 2017 18:25:04 +0200 > Hugo Lefeuvre wrote: >>> If I remove `usr/sbin` from dirs, buildpackage fails complaining >>> that the directory does not exist (so something in the build system >>> is slightly broken). >>

Bug#858860: RFS: arpwatch [ITA]

2017-04-05 Thread Lukas Schwaighofer
Hi Hugo, thanks again for the review and the comments! On Wed, 5 Apr 2017 18:25:04 +0200 Hugo Lefeuvre wrote: > > * debian-watch-may-check-gpg-signature > > I wouldn't override debian-watch-may-check-gpg-signature btw. Ok, I will revert that override. > > If I remove

Bug#858860: RFS: arpwatch [ITA]

2017-04-05 Thread Hugo Lefeuvre
Hi Lukas, > I do not have a web based git viewer installed on my server, however > git clone https://git.somlen.de/arpwatch.git > should work. Remember to switch to the `staged-changes` branch. > > (I should probably create a page explaining that this is a git only url > instead of displaying

Bug#858860: RFS: arpwatch [ITA]

2017-04-04 Thread Lukas Schwaighofer
Hi Hugo, thanks a lot for looking at this. I have made some changes to the package based on your feedback, pushed them to my git repository and uploaded the new version to mentors: https://mentors.debian.net/package/arpwatch Some further questions and comments follow inline below. On Tue, 4

Bug#858860: RFS: arpwatch [ITA]

2017-04-04 Thread Hugo Lefeuvre
Hi Lukas, > > Gianfranco suggested also asking the pkg-security-team for possible > > sponsors. It would be great if one of you could have a look and > > provide guidance! If team maintenance is be possible, I'd like that > > very much. > > I think arpwatch would be a good fit for the team. Is

Bug#858860: RFS: arpwatch [ITA]

2017-04-03 Thread Lukas Schwaighofer
Hi security tools packaging team, On Mon, 27 Mar 2017 23:03:19 +0200 Lukas Schwaighofer wrote: > Gianfranco suggested also asking the pkg-security-team for possible > sponsors. It would be great if one of you could have a look and > provide guidance! If team maintenance