Package: needrestart-session Version: 0.3-4.1 Severity: minor -------- Weitergeleitete Nachricht -------- Betreff: shellcheck results for needrestart-session Datum: Tue, 14 Mar 2017 08:16:20 +0800 Von: Paul Wise <p...@debian.org> Organisation: Debian An: needrestart-sess...@packages.debian.org
Hi all,
I noticed there are a couple of bugs and a style issue in the shell
scripts in the needrestart-session Debian source package:
In ./needrestart-session line 30:
exec /usr/lib/needrestart-session/needrestart-x11 $@
^-- SC2068: Double quote
array expansions to avoid re-splitting elements.
In ./notify.d/300-needrestart-session line 25:
if [ -z "$(ps -Awwo uid,cmd -u "$NR_UID" --no-headers | grep
needrestart-dbus-session)" ]; then
^-- SC2143: Use ! grep -q instead of comparing output with [ -z ..
].
^-- SC2009: Consider using pgrep instead of grepping ps
output.
In ./debian/needrestart-session.postrm line 8:
userdel needrestart-dbus 2>&1 > /dev/null || true
^-- SC2069: The order of the
2>&1 and the redirect matters. The 2>&1 has to be last.
--
bye,
pabs
https://wiki.debian.org/PaulWise
signature.asc
Description: OpenPGP digital signature
