On Fri, 2017-11-10 at 14:36 +0100, Mathieu Parent wrote: > Control: tag -1 + wontfix upstream confirmed > > 2017-11-10 9:33 GMT+01:00 L.P.H. van Belle <be...@bazuin.nl>: > > From the reply from samba.org bugzilla. > > Response: Volker Lendecke 2017-11-10 07:45:25 UTC > > > > WONTFIX might sound harsh, but the fix is not to ship aio_linux in debian. > > > > Linux AIO is not suiteable for samba's file access requirements. > > It only works on O_DIRECT for page-aligned accesses, something Samba does > > not do. > > The fix is to just say "aio write size = 1" and "aio read size = 1" without > > any vfs objects. > > This activates the threaded implementation for async I/O that is > > implemented in core Samba. > > Please transfer this info to the debian package maintainer (if you are not > > the one yourself :-) > > and close the debian bug with the same statement. > > Marking as wontfix here too. > > > Please remove aio_linux from the debian package. > > I suggest to keep it if it has some use. Frank Chung: Why did you use this > vfs?
Please don't keep it. It just confuses folks and the code should have been removed upstream much earlier, and we have an alternative that is much safer. Andrew Bartlett -- Andrew Bartlett https://samba.org/~abartlet/ Authentication Developer, Samba Team https://samba.org Samba Development and Support, Catalyst IT https://catalyst.net.nz/services/samba
