Bug#883682: don't install features-file as conffile for easier overriding

2017-12-08 Thread intrigeri
Hi, Laurent Bigonville: > if a policy creator wants to modify the policy he might need to modify this > file as well same if a user is building his own kernel. There's really no good reason why one would need to modify the default file in /usr: the features-file that the parser uses is configured

Bug#883682: don't install features-file as conffile for easier overriding

2017-12-08 Thread Laurent Bigonville
On Thu, 07 Dec 2017 10:08:54 +0100 intrigeri wrote: [...] > > I think we should: > > - move the features file to a non-conffile location ASAP: not only it > makes little sense for it to be a conffile, but if I manage to get > a pinned feature set in Stretch at some point you'll want this in > ord

Bug#883682: don't install features-file as conffile for easier overriding

2017-12-07 Thread Fabian Grünbichler
On Thu, Dec 07, 2017 at 10:45:11AM +0100, intrigeri wrote: > Fabian Grünbichler: > > sounds like a plan, I'll re-spin my patch later today. > > :) > see attached, tested on Sid with various modification scenarios. I think the messages printed by apt are enough, and there should be no need for a

Bug#883682: don't install features-file as conffile for easier overriding

2017-12-07 Thread intrigeri
Fabian Grünbichler: > sounds like a plan, I'll re-spin my patch later today. :)

Bug#883682: don't install features-file as conffile for easier overriding

2017-12-07 Thread Fabian Grünbichler
On Thu, Dec 07, 2017 at 10:08:54AM +0100, intrigeri wrote: > Hi, > > Fabian Grünbichler: > > On Thu, Dec 07, 2017 at 08:47:52AM +0100, intrigeri wrote: > >> > I am not sure whether we are the only derivative/downstream/.. affected > >> > by this change, but it has the potential to break a lot of s

Bug#883682: don't install features-file as conffile for easier overriding

2017-12-07 Thread intrigeri
Hi, Fabian Grünbichler: > On Thu, Dec 07, 2017 at 08:47:52AM +0100, intrigeri wrote: >> > I am not sure whether we are the only derivative/downstream/.. affected >> > by this change, but it has the potential to break a lot of setups using >> > their own (more recent / patched to support more of AA

Bug#883682: don't install features-file as conffile for easier overriding

2017-12-07 Thread Fabian Grünbichler
On Thu, Dec 07, 2017 at 08:47:52AM +0100, intrigeri wrote: > Control: tag -1 - patch > Control: severity -1 normal > > Hi, hi (no need to CC me, I subscribe to all bugs I submit ;)) > > Fabian Grünbichler: > > see attached patch. > > Thanks! > > > I didn't find a branch for the s-p-u upload (

Bug#883682: don't install features-file as conffile for easier overriding

2017-12-06 Thread intrigeri
Control: tag -1 - patch Control: severity -1 normal Hi, Fabian Grünbichler: > see attached patch. Thanks! > I didn't find a branch for the s-p-u upload (but > that might just be my non-existing bzr skills failing me), https://alioth.debian.org/scm/loggerhead/collab-maint/apparmor-stretch/chang

Bug#883682: don't install features-file as conffile for easier overriding

2017-12-06 Thread Fabian Grünbichler
and actually attaching the patch this time diff --git a/debian/patches/pin-feature-set.patch b/debian/patches/pin-feature-set.patch index c12f1c4..0118aad 100644 --- a/debian/patches/pin-feature-set.patch +++ b/debian/patches/pin-feature-set.patch @@ -15,4 +15,4 @@ Author: intrigeri + +## Pin fe

Bug#883682: don't install features-file as conffile for easier overriding

2017-12-06 Thread Fabian Grünbichler
Control: tags + patch On Wed, Dec 06, 2017 at 11:31:45AM +0100, intrigeri wrote: > Hi, > > Fabian Grünbichler: > > I am not sure whether the features file itself would really need to be a > > conf file though, if it is already pointed to by a conf file directive? > > putting the features file its