Bug#886036: Improve changelog version parsing

Dear Felix, > Both errors were fixed in this merge request. Thank you! > > https://salsa.debian.org/lintian/lintian/merge_requests/20 Ooh, thanks for the speedy turnaround. I'll restrict my review comments to the MR — looking forward to merging it. Feel free to glance around the other

Bug#886036: Improve changelog version parsing

Hi Chris, There were two separate errors. Versions with "0" in any component were not evaluated correctly. (The Perl string "0" is logically false even though it has non-zero length.) A second problem was that versions with "+bzr" triggered false positives for

Bug#886036: Improve changelog version parsing

found 886036 2.5.97 thanks Hi Felix, > * checks/source-changelog.{desc.pm}: >+ [FL] Rework, centralise and improve version parsing. > (Closes: #886036) I'm seeing some false-positives here: https://lintian.debian.org/tags/malformed-debian-changelog-version.html Could you take a

Bug#886036: Improve changelog version parsing

tags 886036 + pending thanks Applied in Git, pending upload: https://salsa.debian.org/lintian/lintian/commit/0005c81dc200a0787a2716aacd6e00f859101c36 checks/cruft.desc| 35 -- checks/cruft.pm | 14

Bug#886036: Improve changelog version parsing

Hi Felix, > Thank you for following up. I have more patches. I am just not sure if the > version parsing should really be duplicated in Lintian. Maybe there is a > benefit to checks and balances, but at least some of the work might well go > into 'dpkg/scripts/Dpkg/Version.pm', which we could

Bug#886036: Improve changelog version parsing

Hi Chris, Thank you for following up. I have more patches. I am just not sure if the version parsing should really be duplicated in Lintian. Maybe there is a benefit to checks and balances, but at least some of the work might well go into 'dpkg/scripts/Dpkg/Version.pm', which we could then use in

Bug#886036: Improve changelog version parsing

Chris Lamb wrote: > Can you update us on the status of this issue? Did we resolve it already > or do you have more patches ready to roll soon? :) Gentle ping on this? I do remember you had some patches queued up, I just hope we/I haven't neglected them somewhere... Regards, -- ,''`.

Bug#886036: Improve changelog version parsing

Hey Felix, > Improve changelog version parsing Can you update us on the status of this issue? Did we resolve it already or do you have more patches ready to roll soon? :) Best wishes, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-

Bug#886036: Improve changelog version parsing

Hi Felix, > * 0001 Addresses an issue when the version contains two hyphens; now > the string is split properly into two parts. Pushed here: https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=f3f373e5365a58d7ee3b126b8f1dfbda557d02a4 > * 0002 Removes an old exception allowing -0.X

Bug#886036: Improve changelog version parsing

Hi Chris! Here are two preliminary bug fixes: * 0001 Addresses an issue when the version contains two hyphens; now the string is split properly into two parts. * 0002 Removes an old exception allowing -0.X on native source NMUs, which now triggers the appropriate warning. The patches were

Bug#886036: Improve changelog version parsing

Hi Felix! > Please have a look at https://github.com/lechner/lintian Woah, looks great! Thank you. Before I merge, can you just… a) Add some tests for the debian-changelog-version-malformed tag. b) Add a changelog entry that closes this bug (#886036) Many thanks again... Best

Bug#886036: Improve changelog version parsing

Dear Chris, On Mon, Jan 1, 2018 at 1:41 PM, Chris Lamb wrote: > (Could you push these to a Git repository somewhere? That would make > them easier to apply... Thanks in advance!) Please have a look at https://github.com/lechner/lintian. The repo contains my locally

Bug#886036: Improve changelog version parsing

Dear Felix, > The patches apply to the 2.5.68 master—one after the other, and > ordered in likelihood of acceptance. Thank you! (Could you push these to a Git repository somewhere? That would make them easier to apply... Thanks in advance!) Best wishes, -- ,''`. : :' : Chris

Bug#886036: Improve changelog version parsing

Package: lintian Version: 2.5.67 Severity: wishlist Tags: patch Hi, The attached patch set improves the version parsing in changelog. The patches are annotated, but I also copied brief descriptions below. The patches apply to the 2.5.68 master—one after the other, and ordered in likelihood of