Bug#886827: RFS: youtube-dl-gui/0.4-1 [ITP]

2018-03-25 Thread Lumin
Hi Félix, I'm sure youtube-dl is working when invoked from command line for downloading an youtube video. However youtube-dl-gui doesn't work with the same URL. I got this from youtube-dl-gui's log, and it seems to be the reason why youtube-dlg doesn't work for me: [Sun Mar 25 07:35:30 2018]

Bug#886827: RFS: youtube-dl-gui/0.4-1 [ITP]

2018-02-22 Thread Félix Sipma
On 2018-02-22 03:27+, Lumin wrote: > I built the package locally, but I did not get it working correctly > With a YouTube URL. It downloads nothing. > Could you please provide a url for test so I can make sure > it is working? > > I will look into this problem later. It definitely works

Bug#886827: RFS: youtube-dl-gui/0.4-1 [ITP]

2018-02-21 Thread Lumin
On Fri, 16 Feb 2018 at 01:22 Félix Sipma wrote: > > > This part seems unrelated to auto update functionality. Would you > > mind splitting it to another patch? > > It is a part of the patch: youtube-dl-gui tries to download youtube-dl in > 'youtubedl_path', and then

Bug#886827: RFS: youtube-dl-gui/0.4-1 [ITP]

2018-02-15 Thread Félix Sipma
On 2018-02-15 16:23+, Lumin wrote: > One more problem: > > 146 diff --git a/youtube_dl_gui/optionsmanager.py > b/youtube_dl_gui/optionsmanager.py > 147 index 794f590..baa6b83 100644 > 148 --- a/youtube_dl_gui/optionsmanager.py > 149 +++ b/youtube_dl_gui/optionsmanager.py > 150 @@ -276,7

Bug#886827: RFS: youtube-dl-gui/0.4-1 [ITP]

2018-02-15 Thread Lumin
On 15 February 2018 at 15:33, Félix Sipma wrote: > I don't get the harm in having a little more verbose initial changelog, we're > talking about 10 lines there, not a whole book... Anyway, I've just kept the > attribution and a line mentioning the lack of python3 support.

Bug#886827: Fwd: Bug#886827: RFS: youtube-dl-gui/0.4-1 [ITP]

2018-02-15 Thread Lumin
-- Forwarded message -- From: Lumin <cdlumin...@gmail.com> Date: 15 February 2018 at 14:51 Subject: Re: Bug#886827: RFS: youtube-dl-gui/0.4-1 [ITP] To: Félix Sipma <felix+deb...@gueux.org> Hi, On 15 February 2018 at 09:41, Félix Sipma <felix+deb...@gueux.org> w

Bug#886827: RFS: youtube-dl-gui/0.4-1 [ITP]

2018-02-15 Thread Félix Sipma
Control: tag -1 -moreinfo Hi, Thanks for your review. Changelog: is there a problem with being more verbose? I like writing about specificities of a package and it's one of the places (with debian/rules) where I did write a comment concerning python3 support (needs python3-wxgtk3.0). > compat

Bug#886827: RFS: youtube-dl-gui/0.4-1 [ITP]

2018-02-15 Thread Lumin
control: owner -1 ! control: tag -1 +moreinfo Hi Félix, Some comments on your package: changelog --- * One line is enough for the initial upload, e.g. "Initial release. (Closes: #753350)" compat & control - * I'd recommend to use debhelper compat