Source: ifhp Version: 3.5.20-15 Severity: important User: debian-...@lists.debian.org Usertag: ftbfs-gcc-8
Hi, I recently performed an (unofficial) archive rebuild with GCC 8 on mips64el. The main purpose of the rebuild was to discover mips toolchain regressions, however I noticed this error in the logs which might be interesting to you: > ifhp.c: In function 'Find_sub_value': > ifhp.c:2803:3: error: 'strncpy' specified bound 128 equals destination size > [-Werror=stringop-truncation] > strncpy(copy,id+1,sizeof(copy)); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > <builtin>: recipe for target 'ifhp.o' failed > make[2]: *** [ifhp.o] Error 1 > make[2]: Leaving directory '/<<PKGBUILDDIR>>/src' > Makefile:51: recipe for target 'src' failed > make[1]: *** [src] Error 2 > make[1]: Leaving directory '/<<PKGBUILDDIR>>' > debian/rules:32: recipe for target 'build-stamp' failed > make: *** [build-stamp] Error 2 > dpkg-buildpackage: error: debian/rules build-arch subprocess returned exit > status 2 As you probably know, you need to be careful using strncpy. Instead of: char out[SIZE]; strncpy(out, in, SIZE); You need to do: char out[SIZE] strncpy(out, in, SIZE - 1); out[SIZE - 1] = '\0'; See strcpy(3) James
signature.asc
Description: OpenPGP digital signature
