Bug#903399: Fix makes old-python-version-field field untestable (was: "Re: Bug#903399: Fix makes tag untestable")

2019-02-22 Thread Chris Lamb
Hi Felix, > > Not sure how we can get around this. Have you implemented similar > > things for other tags...? > > So far I have not faked a test, but sed will do a great job. Could the > Python minor number differ between the tags? I don't understand what you mean by "differ". X-Python3-Version

Bug#903399: Fix makes tag untestable

2019-02-21 Thread Felix Lechner
On Thu, Feb 21, 2019 at 11:51 AM Chris Lamb wrote: > Not sure how we can get around this. Have you implemented similar > things for other tags...? The best alternative would be for the test to read the the value from data/python/versions when constructing the test package. That way the test

Bug#903399: Fix makes tag untestable

2019-02-21 Thread Felix Lechner
On Thu, Feb 21, 2019 at 11:51 AM Chris Lamb wrote: > > Not sure how we can get around this. Have you implemented similar > things for other tags...? So far I have not faked a test, but sed will do a great job. Could the Python minor number differ between the tags?

Bug#903399: Fix makes tag untestable

2019-02-21 Thread Chris Lamb
Hi Felix, > The fix for this bug makes the tag 'old-python-version-field' > untestable. When the version for old-python equals ancient-python, > there is no way to reach the second block: > > if (versions_lte($v, $ancient)) { > tag 'ancient-python-version-field',

Bug#903399: Fix makes tag untestable

2019-02-21 Thread Felix Lechner
The fix for this bug makes the tag 'old-python-version-field' untestable. When the version for old-python equals ancient-python, there is no way to reach the second block: if (versions_lte($v, $ancient)) { tag 'ancient-python-version-field', $field, $v; }