Control: tags -1 + patch
On Wed, Jul 18, 2018 at 11:06:28PM +0200, Andreas Henriksson wrote:
> Source: netkit-telnet
[...]
> If time permits and I haven't heard anything back I'll consider fixing
> this via a NMU while at DebCamp/DebConf.
I'm attaching patch to implement the suggested change. It's been tested
using piuparts. Please reply if you'd like to incorporate this or if
you prefer I go ahead with NMU.
Regards,
Andreas Henriksson
diff -Nru netkit-telnet-0.17/debian/changelog
netkit-telnet-0.17/debian/changelog
--- netkit-telnet-0.17/debian/changelog 2016-11-07 19:06:40.000000000 +0100
+++ netkit-telnet-0.17/debian/changelog 2018-07-28 15:49:47.000000000 +0200
@@ -1,3 +1,14 @@
+netkit-telnet (0.17-41.1) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * Replace sg usage with getent group in postinst (Closes: #904046)
+ - note that there's still much room for related improvements, like
+ using 'getent passwd' instead of id to match the common pattern
+ also don't remove the user in postrm as that violates the
+ common consensus (see discussion linked from #228692)
+
+ -- Andreas Henriksson <andr...@fatal.se> Sat, 28 Jul 2018 15:49:47 +0200
+
netkit-telnet (0.17-41) unstable; urgency=low
* Declare Standards version as 3.9.8, no changes.
diff -Nru netkit-telnet-0.17/debian/telnetd.postinst
netkit-telnet-0.17/debian/telnetd.postinst
--- netkit-telnet-0.17/debian/telnetd.postinst 2016-11-05 14:51:10.000000000
+0100
+++ netkit-telnet-0.17/debian/telnetd.postinst 2018-07-28 15:48:59.000000000
+0200
@@ -14,7 +14,7 @@
}
if ! id -u telnetd >/dev/null 2>&1; then
- if sg telnetd -c true 2>/dev/null; then
+ if getent group telnetd >/dev/null; then
adduser --quiet --no-create-home --disabled-password --system
--ingroup telnetd --home /nonexistent telnetd
else
adduser --quiet --no-create-home --disabled-password --system
--group --home /nonexistent telnetd
