Bug#904250: RFS - golang-github-ulule-limiter - don't skip all tests

2018-07-29 Thread Paride Legovini
On Sun, 29 Jul 2018 Paride Legovini wrote: > Alexandre Viau wrote on 29/07/2018: > > On 2018-07-29 04:58 AM, Julien Rouhaud wrote: > >> I just noticed that the s/MIT/Expat/ in 1a37607957 also modified > >> LIMITED. I'm new here so unfortunately I don't know if I should do > >> more than this

Bug#904250: RFS - golang-github-ulule-limiter - don't skip all tests

2018-07-29 Thread Paride Legovini
Alexandre Viau wrote on 29/07/2018: > On 2018-07-29 04:58 AM, Julien Rouhaud wrote: >> I just noticed that the s/MIT/Expat/ in 1a37607957 also modified >> LIMITED. I'm new here so unfortunately I don't know if I should do >> more than this email. > > That would be important to fix. > > I have

Bug#904250: RFS - golang-github-ulule-limiter - don't skip all tests

2018-07-29 Thread Julien Rouhaud
On Sun, Jul 29, 2018 at 11:47 AM, Alexandre Viau wrote: > On 2018-07-29 04:58 AM, Julien Rouhaud wrote: >> I just noticed that the s/MIT/Expat/ in 1a37607957 also modified >> LIMITED. I'm new here so unfortunately I don't know if I should do >> more than this email. > > That would be important

Bug#904250: RFS - golang-github-ulule-limiter - don't skip all tests

2018-07-29 Thread Alexandre Viau
On 2018-07-29 04:58 AM, Julien Rouhaud wrote: > I just noticed that the s/MIT/Expat/ in 1a37607957 also modified > LIMITED. I'm new here so unfortunately I don't know if I should do > more than this email. That would be important to fix. I have prepared and uploaded a new version, there is else

Bug#904250: RFS - golang-github-ulule-limiter - don't skip all tests

2018-07-29 Thread Julien Rouhaud
Hi, On Sun, Jul 29, 2018 at 7:52 AM, Alexandre Viau wrote: > On 2018-07-28 05:49 AM, Paride Legovini wrote: >> Alexandre Viau wrote on 28/07/2018: >> [...] >> I think I've found a better way to skip that test, without patching. >> Please check my last commits when you have time. > > This is

Bug#904250: RFS - golang-github-ulule-limiter - don't skip all tests

2018-07-28 Thread Alexandre Viau
On 2018-07-28 05:49 AM, Paride Legovini wrote: > Alexandre Viau wrote on 28/07/2018: >> Hello, >> >> I have noticed that you skip all tests in golang-github-ulule-limiter. >> >> However, there is only two tests that require redis. >> >> I think that it would be best to skip only these two tests.

Bug#904250: RFS - golang-github-ulule-limiter - don't skip all tests

2018-07-28 Thread Paride Legovini
Alexandre Viau wrote on 28/07/2018: > Hello, > > I have noticed that you skip all tests in golang-github-ulule-limiter. > > However, there is only two tests that require redis. > > I think that it would be best to skip only these two tests. > > You can simply write a patch that adds t.Skip()

Bug#904250: RFS - golang-github-ulule-limiter - don't skip all tests

2018-07-27 Thread Alexandre Viau
Hello, I have noticed that you skip all tests in golang-github-ulule-limiter. However, there is only two tests that require redis. I think that it would be best to skip only these two tests. You can simply write a patch that adds t.Skip() to these tests. Cheers, -- Alexandre Viau