Package: autopkgtest
Version: 5.4.1
Severity: grave
Justification: renders package unusable

Dear autopkgtest Maintainers,

In various situations autopkgtest calls /bin/su with an empty string for
the username. The old su (from login) ignored this, but newer su
versions (from util-linux 2.32-0.2) do not accept this, and abort.
Personally I think autopkgtest got lucky that this worked before, but
this probably was not a valid thing to do.

One of the affected lines:
   https://sources.debian.org/src/autopkgtest/5.4.1/lib/adt_testbed.py/#L1096

Example output from autopkgtest:

   autopkgtest [15:52:36]: test supported-algos: [-----------------------
   su: user  does not exist
   autopkgtest [15:52:36]: test supported-algos: -----------------------]
   Unexpected error:
   Traceback (most recent call last):
     File "/usr/share/autopkgtest/lib/VirtSubproc.py", line 717, in mainloop
       command()
     File "/usr/share/autopkgtest/lib/VirtSubproc.py", line 646, in command
       r = f(c, ce)
     File "/usr/share/autopkgtest/lib/VirtSubproc.py", line 584, in cmd_copyup
       copyupdown(c, ce, True)
     File "/usr/share/autopkgtest/lib/VirtSubproc.py", line 469, in copyupdown
       copyupdown_internal(ce[0], c[1:], upp)
     File "/usr/share/autopkgtest/lib/VirtSubproc.py", line 494, in 
copyupdown_internal
       copyup_shareddir(sd[0], sd[1], dirsp, downtmp_host)
     File "/usr/share/autopkgtest/lib/VirtSubproc.py", line 408, in 
copyup_shareddir
       shutil.copy(tb, host)
     File "/usr/lib/python3.6/shutil.py", line 241, in copy
       copyfile(src, dst, follow_symlinks=follow_symlinks)
     File "/usr/lib/python3.6/shutil.py", line 120, in copyfile
       with open(src, 'rb') as fsrc:
   FileNotFoundError: [Errno 2] No such file or directory: 
'/tmp/autopkgtest.zwqy11/supported-algos-stdout'
   autopkgtest [15:52:36]: ERROR: testbed failure: cannot send to testbed: 
[Errno 32] Broken pipe
   autopkgtest [15:52:36]: Binaries: resetting testbed apt configuration

Note that tests that say "Restrictions: needs-root" do not appear to hit
those code paths.

I might try to come up with a patch if no one beats me to it.

Chris

Reply via email to