Package: gnome-shell-extension-workspaces-to-dock
Version: 45-1
Severity: important
Tags: upstream buster sid
Control: block 906016 by -1

gjs 1.53.90+ switches its Javascript implementation from mozjs52 to
mozjs60, a newer Mozilla Spidermonkey release which drops some
Mozilla-proprietary extensions. A gjs maintainer has developed a tool,
<https://gitlab.gnome.org/ptomato/moz60tool>, which can be used to check
for most of the problem cases.

When I ran that tool against this package I got warnings:

./gnome-shell-extension-workspaces-to-dock-45/workspaces-to-d...@passingthru67.gmail.com/placeDisplay.js:59:16:
 Conditional catch clause used.
  WRONG:   catch (e if e.code === 23) {...}
  CORRECT: catch (e) { if (e.code === 23) {...} }
./gnome-shell-extension-workspaces-to-dock-45/workspaces-to-d...@passingthru67.gmail.com/placeDisplay.js:73:16:
 Conditional catch clause used.
  WRONG:   catch (e if e.code === 23) {...}
  CORRECT: catch (e) { if (e.code === 23) {...} }
./gnome-shell-extension-workspaces-to-dock-45/workspaces-to-d...@passingthru67.gmail.com/placeDisplay.js:95:16:
 Conditional catch clause used.
  WRONG:   catch (e if e.code === 23) {...}
  CORRECT: catch (e) { if (e.code === 23) {...} }
./gnome-shell-extension-workspaces-to-dock-45/workspaces-to-d...@passingthru67.gmail.com/placeDisplay.js:136:20:
 Conditional catch clause used.
  WRONG:   catch (e if e.code === 23) {...}
  CORRECT: catch (e) { if (e.code === 23) {...} }
4 errors found.

This might have already been fixed upstream for GNOME 3.30. The GNOME
team is in the process of uploading GNOME 3.30 to experimental; this bug
will be escalated to RC when GNOME 3.30 is ready for upload to unstable.

gjs will need to have a Breaks against unfixed versions.

Regards,
    smcv

Reply via email to