Bug#911403: Please always include a copyright notice in 'LicenseWithSummary::summary_or_text'

2018-10-29 Thread Felix Lechner
Hi Dominique, I am fine with your suggestion. We will wait for your implementation. Thank you for providing this package! Kind regards, Felix On Mon, Oct 29, 2018 at 9:44 AM Dominique Dumont wrote: > > On Monday, 29 October 2018 16:51:45 CET you wrote: > > I am happy to provide patches and

Bug#911403: Please always include a copyright notice in 'LicenseWithSummary::summary_or_text'

2018-10-29 Thread Dominique Dumont
On Monday, 29 October 2018 16:51:45 CET you wrote: > I am happy to provide patches and merge requests that implement your > idea, Thanks. But the change is trivial. I can do it on my side. We just need to find a common ground that allow fixing #905614 > but are you sure there are other

Bug#911403: Please always include a copyright notice in 'LicenseWithSummary::summary_or_text'

2018-10-29 Thread Dominique Dumont
On Monday, 29 October 2018 15:21:25 CET you wrote: > I'm not thrilled at the idea of changing the behavior of summary_or_text > method because the implementation would no longer match its behavior. Oops, this sentence does not make sense. I meant that "the function name would no longer match its

Bug#911403: Please always include a copyright notice in 'LicenseWithSummary::summary_or_text'

2018-10-29 Thread Felix Lechner
Hi Dominique, I am happy to provide patches and merge requests that implement your idea, but are you sure there are other meaningful consumers of the summary_or_text method? Your posting [1] restricts uses to Debian, and a search on codesearch.debian.net shows no other packages that rely on the

Bug#911403: Please always include a copyright notice in 'LicenseWithSummary::summary_or_text'

2018-10-29 Thread Dominique Dumont
On Sat, 27 Oct 2018 15:57:56 +0200 gregor herrmann wrote: > Dominique, could you look into this patch, please? yes, sorry for the delay. I'm not thrilled at the idea of changing the behavior of summary_or_text method because the implementation would no longer match its behavior. Felix, how

Bug#911403: Please always include a copyright notice in 'LicenseWithSummary::summary_or_text'

2018-10-27 Thread gregor herrmann
On Fri, 19 Oct 2018 10:55:25 -0700, Felix Lechner wrote: > The routine 'LicenseWithSummary::summary' produces only a license > summary, while 'Software::License::fulltext' produces a copyright > notice in addition to the full text. Please return a copyright notice > when producing a summary in

Bug#911403: Please always include a copyright notice in 'LicenseWithSummary::summary_or_text'

2018-10-19 Thread Felix Lechner
Package: libsoftware-licensemoreutils-perl Version: 1.002-1 Tags: patch Control: block 905614 by -1 Hi, The routine 'LicenseWithSummary::summary' produces only a license summary, while 'Software::License::fulltext' produces a copyright notice in addition to the full text. Please return a