Package: armadillo
Version: 1:9.200.6+dfsg-1
Tags: patch
Per the author's report below.
Kumar
--
Kumar Appaiah
--- Begin Message ---
Hi Kumar,
I've discovered a serious bug in Armadillo 9.200.6, where the trace()
function can lead to incorrect results when applied to compound
expressions with complex matrices.
Attached is a small patch for Armadillo 9.200.6 which fixes the bug.
The patch changes only 1 line and does not introduce any new
functionality. It is a pure bug fix patch.
Could you apply this patch to the Debian armadillo package ? It would
be good to have this before upcoming freeze.
An alternative solution is to upgrade the Debian armadillo package to
version 9.200.7, which also contains the fix.
With regards,
Conrad
On Tue, 11 Dec 2018 at 15:39, Kumar Appaiah <a.ku...@alumni.iitm.ac.in> wrote:
>
> Dear Conrad,
>
> On Tue, Dec 11, 2018 at 02:15:38PM +1000, Conrad Sand wrote:
> > Hi Kumar,
> >
> > I've released Armadillo 9.200, which contains bug fixes,
> > new functions, improvements and many speedups.
> >
> > I recommend upgrading the corresponding Debian and Ubuntu packages.
> >
> > http://sourceforge.net/projects/arma/files/armadillo-9.200.6.tar.xz
> >
> [snip]
> >
> > With regards,
> > Conrad
>
>
> Done. Thanks for contributing to Debian!
>
> Kumar
> --
> Kumar Appaiah
diff -r -u armadillo-9.200.6-a/include/armadillo_bits/fn_trace.hpp armadillo-9.200.6-b/include/armadillo_bits/fn_trace.hpp
--- armadillo-9.200.6-a/include/armadillo_bits/fn_trace.hpp 2016-06-17 02:19:16.000000000 +1000
+++ armadillo-9.200.6-b/include/armadillo_bits/fn_trace.hpp 2016-06-17 02:19:16.000000000 +1000
@@ -82,7 +82,7 @@
template<typename T1, typename T2>
arma_warn_unused
inline
-typename T1::elem_type
+typename enable_if2< is_cx<typename T1::elem_type>::no, typename T1::elem_type>::result
trace(const Glue<T1, T2, glue_times>& X)
{
arma_extra_debug_sigprint();
--- End Message ---
