Bug#922264: pkg-perl-autopkgtest: use "skippable" and "superficial" restrictions

2019-02-23 Thread Xavier
Le 23/02/2019 à 18:32, gregor herrmann a écrit : > On Sat, 16 Feb 2019 19:52:06 +0200, Niko Tyni wrote: > >> I agree with the intention here. The only non-superficial test of the >> current ones is indeed the 'smoke' test. > > Cool, thanks. > >> However, I have an "architectural" concern. > >

Bug#922264: pkg-perl-autopkgtest: use "skippable" and "superficial" restrictions

2019-02-23 Thread gregor herrmann
On Sat, 16 Feb 2019 19:52:06 +0200, Niko Tyni wrote: > I agree with the intention here. The only non-superficial test of the > current ones is indeed the 'smoke' test. Cool, thanks. > However, I have an "architectural" concern. […] Makes sense. Maybe material for the next sprint? > Please

Bug#922264: pkg-perl-autopkgtest: use "skippable" and "superficial" restrictions

2019-02-16 Thread Niko Tyni
On Fri, Feb 15, 2019 at 08:55:16PM +0100, gregor herrmann wrote: > > > - As for the implementation in [0]: > > > not sure if the "exit 0" in smoke is correct > > This still confuses me. > Shouldn't it "exit $?" or just nothing (line 174)? It's a "set -e" script so a failure from test.pl

Bug#922264: pkg-perl-autopkgtest: use "skippable" and "superficial" restrictions

2019-02-16 Thread Niko Tyni
On Wed, Feb 13, 2019 at 09:23:00PM +0100, Xavier Guimard wrote: > Package: pkg-perl-autopkgtest > Version: 0.50 > Severity: wishlist > - tests skipped should return a 77 exit code and all tests marked as >"Restrictions: skippable". It avoids to consider that a test succeeds >if

Bug#922264: pkg-perl-autopkgtest: use "skippable" and "superficial" restrictions

2019-02-15 Thread gregor herrmann
On Fri, 15 Feb 2019 18:29:14 +0100, Xavier wrote: > > For the skippable part: > > - If I understand this correctly (from your text above and the spec > > [1]) then a skipped syntax.t and use.t would also lead to losing > > the benefit of faster migration? Do we want this? > The benefit will

Bug#922264: pkg-perl-autopkgtest: use "skippable" and "superficial" restrictions

2019-02-15 Thread Xavier
Le 15/02/2019 à 18:29, Xavier a écrit : > Le 15/02/2019 à 17:57, gregor herrmann a écrit : >> On Wed, 13 Feb 2019 21:23:00 +0100, Xavier Guimard wrote: >> >>> Some suggestions for pkg-js-autopkgtest based on pkg-js-autopkgtest >>> discussion with autodep8 maintainers: >>> - tests skipped should

Bug#922264: pkg-perl-autopkgtest: use "skippable" and "superficial" restrictions

2019-02-15 Thread Xavier
Le 15/02/2019 à 17:57, gregor herrmann a écrit : > On Wed, 13 Feb 2019 21:23:00 +0100, Xavier Guimard wrote: > >> Some suggestions for pkg-js-autopkgtest based on pkg-js-autopkgtest >> discussion with autodep8 maintainers: >> - tests skipped should return a 77 exit code and all tests marked as

Bug#922264: pkg-perl-autopkgtest: use "skippable" and "superficial" restrictions

2019-02-15 Thread gregor herrmann
On Wed, 13 Feb 2019 21:23:00 +0100, Xavier Guimard wrote: > Some suggestions for pkg-js-autopkgtest based on pkg-js-autopkgtest > discussion with autodep8 maintainers: > - tests skipped should return a 77 exit code and all tests marked as >"Restrictions: skippable". It avoids to consider

Bug#922264: pkg-perl-autopkgtest: use "skippable" and "superficial" restrictions

2019-02-13 Thread Xavier Guimard
Package: pkg-perl-autopkgtest Version: 0.50 Severity: wishlist Hi all, Some suggestions for pkg-js-autopkgtest based on pkg-js-autopkgtest discussion with autodep8 maintainers: - tests skipped should return a 77 exit code and all tests marked as "Restrictions: skippable". It avoids to