Bug#927154: aborts on window size change

2019-10-15 Thread Antoine Beaupré
On 2019-10-14 16:09:22, Niko Tyni wrote: > Control: tag -1 patch > > On Tue, Apr 16, 2019 at 01:03:28PM -0400, Antoine Beaupré wrote: > >> Okay, so here's an interesting data point. On Debian stretch, I can't >> reproduce the bug, even when running from git, using on current master >> (1.20180726

Bug#927154: aborts on window size change

2019-10-14 Thread Niko Tyni
On Mon, Oct 14, 2019 at 10:42:26PM +0800, Paul Wise wrote: > Any idea why something similar doesn't also happen in the loop above, > where getline would return undef on error, terminating the loop? getline() has a different interface and restarts interrupted read(2) calls internally. It's like <>

Bug#927154: aborts on window size change

2019-10-14 Thread Paul Wise
Control: tags -1 + fixed-upstream Control: forwarded -1 http://source.myrepos.branchable.com/?p=source.git;a=commitdiff;h=0d8dc60c227cf5868e568c7fa30ebec1f770d521 On Mon, 2019-10-14 at 16:09 +0300, Niko Tyni wrote: > Maybe you didn't have libio-pty-easy-perl installed on the stretch system > as

Bug#927154: aborts on window size change

2019-10-14 Thread Niko Tyni
Control: tag -1 patch On Tue, Apr 16, 2019 at 01:03:28PM -0400, Antoine Beaupré wrote: > Okay, so here's an interesting data point. On Debian stretch, I can't > reproduce the bug, even when running from git, using on current master > (1.20180726-30-g6cf8003). > > So maybe something else is goin

Bug#927154: aborts on window size change

2019-10-13 Thread Paul Wise
On Sun, 2019-10-13 at 16:37 +0800, Paul Wise wrote: > I managed to get a little bit further in the bisect using the attached > script but I hit a point where the commit isn't easily backportable, > I'll try to continue the backporting another day, spent too long today. I thought about it a bit mo

Bug#927154: aborts on window size change

2019-10-13 Thread Paul Wise
On Sun, 2019-10-13 at 15:14 +0800, Paul Wise wrote: > Did you manage to work out how to bisect this? I managed to get a little bit further in the bisect using the attached script but I hit a point where the commit isn't easily backportable, I'll try to continue the backporting another day, spent

Bug#927154: aborts on window size change

2019-10-13 Thread Paul Wise
On Tue, 16 Apr 2019 13:03:28 -0400 Antoine Beaupré wrote: > Okay, so here's an interesting data point. On Debian stretch, I can't > reproduce the bug, even when running from git, using on current master > (1.20180726-30-g6cf8003). > > So maybe something else is going on here, outside of myrepos i

Bug#927154: aborts on window size change

2019-04-16 Thread Antoine Beaupré
On 2019-04-16 15:03:54, Paul Wise wrote: > On Tue, 2019-04-16 at 00:26 -0400, Antoine Beaupré wrote: > >> Ouch? Any practical way to do that? > > I think a normal `git bisect` but running `git cherry-pick` before > doing tests should work, untested though. > >> And how would i reliable backport tha

Bug#927154: aborts on window size change

2019-04-16 Thread Paul Wise
On Tue, 2019-04-16 at 00:26 -0400, Antoine Beaupré wrote: > Ouch? Any practical way to do that? I think a normal `git bisect` but running `git cherry-pick` before doing tests should work, untested though. > And how would i reliable backport that patch systematically within > bisect anyways? Loo

Bug#927154: aborts on window size change

2019-04-15 Thread Antoine Beaupré
On 2019-04-16 08:16:39, Paul Wise wrote: > On Mon, 2019-04-15 at 13:21 -0400, Antoine Beaupré wrote: > >> Sure. Bisect tells me this one introduces the bug: > > Thanks for that. > >> I hope that helps. > > That commit fixes a pretty major bug, so I think that maybe the issue > was present all along

Bug#927154: aborts on window size change

2019-04-15 Thread Paul Wise
On Mon, 2019-04-15 at 13:21 -0400, Antoine Beaupré wrote: > Sure. Bisect tells me this one introduces the bug: Thanks for that. > I hope that helps. That commit fixes a pretty major bug, so I think that maybe the issue was present all along but masked by not using the right loop terminator. I

Bug#927154: aborts on window size change

2019-04-15 Thread Antoine Beaupré
On 2019-04-16 00:55:17, Paul Wise wrote: > On Mon, 2019-04-15 at 12:10 -0400, Antoine Beaupre wrote: > >> Somewhere between 1.20160123 (debian stretch) and 1.20180726, myrepos >> acquired this strange behavior that window change signals >> (SIGWINCH/28?) seem to crash the program completely, when r

Bug#927154: aborts on window size change

2019-04-15 Thread Paul Wise
On Mon, 2019-04-15 at 12:10 -0400, Antoine Beaupre wrote: > Somewhere between 1.20160123 (debian stretch) and 1.20180726, myrepos > acquired this strange behavior that window change signals > (SIGWINCH/28?) seem to crash the program completely, when running in > paralell (-j) and minimal (-m). I'

Bug#927154: aborts on window size change

2019-04-15 Thread Antoine Beaupre
Package: myrepos Version: 1.20180726 Severity: normal Tags: upstream Somewhere between 1.20160123 (debian stretch) and 1.20180726, myrepos acquired this strange behavior that window change signals (SIGWINCH/28?) seem to crash the program completely, when running in paralell (-j) and minimal (-m).