[2019-08-15 17:59] Paride Legovini
> Dmitry Bogatov wrote on 06/08/2019:
> > So, please:
> >
> > * drop --as-needed
> > * fix spelling
> > * finalize changelog (dch -r)
>
> Done.
Uploaded. Tagged. Permissions granted.
--
Note, that I send and fetch email in batch, once in a few days.
Dmitry Bogatov wrote on 06/08/2019:
> So, please:
>
> * drop --as-needed
> * fix spelling
> * finalize changelog (dch -r)
Done.
Paride
Dmitry Bogatov wrote on 06/08/2019:
>
> [2019-08-05 22:33] Paride Legovini
>> Dmitry Bogatov wrote on 23/07/2019:
>>> [2019-07-21 11:36] Paride Legovini
> 1. In [942ed5e] you added this line:
>
> export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed
>> [...]
>> That's my understanding
[2019-08-05 22:33] Paride Legovini
> Dmitry Bogatov wrote on 23/07/2019:
> > [2019-07-21 11:36] Paride Legovini
> >>> 1. In [942ed5e] you added this line:
> >>>
> >>> export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed
> [...]
> That's my understanding too. In this case I'm pretty sure the
Dmitry Bogatov wrote on 23/07/2019:
> [2019-07-21 11:36] Paride Legovini
>>> 1. In [942ed5e] you added this line:
>>>
>>> export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed
>>>
>>>Why is it needed? Maybe, these flags should be provided by
>>>dpkg-buildflags(1)?
>>
>> dpkg-buildflags
control: clone 932438 -2
control: reassign -2 irqbalance
control: retitle -2 add support for oneshot invocation with runit
control: owner -2 kact...@debian.org
[2019-07-21 11:36] Paride Legovini
> > 1. In [942ed5e] you added this line:
> >
> > export DEB_LDFLAGS_MAINT_APPEND =
Paride Legovini wrote on 21/07/2019:
> Dmitry Bogatov wrote on 20/07/2019:
>>* current runscript does not respect ONESHOT option. It can be fixed
>> with something like
>>
>>#!/bin/sh
>>. /etc/default/irqbalance
>>if [ -n "${ONESHOT:-}" ] ; then
>>
Hi Dmitry, thanks for your review.
Dmitry Bogatov wrote on 20/07/2019:
> [2019-07-19 12:57] Paride Legovini
>> Package: sponsorship-requests
>> Severity: normal
>>
>> Please review my packaging branch for irqbalance/1.6.0-1 at:
>>
>> https://salsa.debian.org/paride-guest/irqbalance
>> [...]
>
[2019-07-19 12:57] Paride Legovini
> Package: sponsorship-requests
> Severity: normal
>
> Please review my packaging branch for irqbalance/1.6.0-1 at:
>
> https://salsa.debian.org/paride-guest/irqbalance
> [...]
On your changes:
1. In [942ed5e] you added this line:
export
I fixed the spelling errors lintian complains about upstream:
https://github.com/Irqbalance/irqbalance/commit/c30406b2b6f0e9c23b7
Paride
Package: sponsorship-requests
Severity: normal
Please review my packaging branch for irqbalance/1.6.0-1 at:
https://salsa.debian.org/paride-guest/irqbalance
In the beginning I thought this was going to be an easy one, it turned
out not to be the case. This means that even the review won't be
11 matches
Mail list logo
